From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v2] clk: tegra: Use readl_relaxed_poll_timeout_atomic in tegra210_clock_init Date: Thu, 19 Oct 2017 02:29:20 -0700 Message-ID: <20171019092919.GA7252@Asurada> References: <1505502613-11801-1-git-send-email-nicoleotsuka@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1505502613-11801-1-git-send-email-nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Fri, Sep 15, 2017 at 12:10:13PM -0700, Nicolin Chen wrote: > Below is the call trace of tegra210_init_pllu() function: > start_kernel() > -> time_init() > --> of_clk_init() > ---> tegra210_clock_init() > ----> tegra210_pll_init() > -----> tegra210_init_pllu() > > Because the preemption is disabled in the start_kernel before calling > time_init, tegra210_init_pllu is actually in an atomic context while > it includes a readl_relaxed_poll_timeout that might sleep. > > So this patch just changes this readl_relaxed_poll_timeout() to its > atomic version. > > Signed-off-by: Nicolin Chen > Acked-By: Peter De Schrijver Thierry, can you also take a look at this one? I sent a month ago. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752401AbdJSJ3z (ORCPT ); Thu, 19 Oct 2017 05:29:55 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:56645 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbdJSJ3v (ORCPT ); Thu, 19 Oct 2017 05:29:51 -0400 X-Google-Smtp-Source: ABhQp+Rb5APAxPDKfDibJmydmcemJ/EAxDdQvdltNchZKW2aD38zDc+0vp+0WBZPJ4QUGQapa/Kpuw== Date: Thu, 19 Oct 2017 02:29:20 -0700 From: Nicolin Chen To: thierry.reding@gmail.com, sboyd@codeaurora.org, pdeschrijver@nvidia.com Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, jonathanh@nvidia.com, mturquette@baylibre.com, pgaikwad@nvidia.com Subject: Re: [PATCH v2] clk: tegra: Use readl_relaxed_poll_timeout_atomic in tegra210_clock_init Message-ID: <20171019092919.GA7252@Asurada> References: <1505502613-11801-1-git-send-email-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505502613-11801-1-git-send-email-nicoleotsuka@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2017 at 12:10:13PM -0700, Nicolin Chen wrote: > Below is the call trace of tegra210_init_pllu() function: > start_kernel() > -> time_init() > --> of_clk_init() > ---> tegra210_clock_init() > ----> tegra210_pll_init() > -----> tegra210_init_pllu() > > Because the preemption is disabled in the start_kernel before calling > time_init, tegra210_init_pllu is actually in an atomic context while > it includes a readl_relaxed_poll_timeout that might sleep. > > So this patch just changes this readl_relaxed_poll_timeout() to its > atomic version. > > Signed-off-by: Nicolin Chen > Acked-By: Peter De Schrijver Thierry, can you also take a look at this one? I sent a month ago. Thanks.