From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbdJSJh7 (ORCPT ); Thu, 19 Oct 2017 05:37:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46860 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbdJSJhz (ORCPT ); Thu, 19 Oct 2017 05:37:55 -0400 Date: Thu, 19 Oct 2017 11:38:02 +0200 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christophe JAILLET , Sasha Levin Subject: Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to free_irq Message-ID: <20171019093802.GF20059@kroah.com> References: <20171006083705.157012217@linuxfoundation.org> <20171006083707.525851713@linuxfoundation.org> <1508183166.22379.41.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1508183166.22379.41.camel@codethink.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 08:46:06PM +0100, Ben Hutchings wrote: > On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.  If anyone has any objections, please let me > > know. > > > > ------------------ > > > > From: Christophe JAILLET > > > > > > [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ] > > > > 'request_irq()' and 'free_irq()' should be called with the same > > dev_id. > [...] > > This fixes a bug introduced in 4.6 by commit 465893e18878 "tty: > goldfish: support platform_device with id -1". For earlier kernel > versions, it *introduces* a bug. > > Please revert from the 3.18 and 4.4 branches. Ugh, the goldfish drivers are a pain lately... I'll go revert this, luckily no one actually runs them in the tree :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:46860 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbdJSJhz (ORCPT ); Thu, 19 Oct 2017 05:37:55 -0400 Date: Thu, 19 Oct 2017 11:38:02 +0200 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christophe JAILLET , Sasha Levin Subject: Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to free_irq Message-ID: <20171019093802.GF20059@kroah.com> References: <20171006083705.157012217@linuxfoundation.org> <20171006083707.525851713@linuxfoundation.org> <1508183166.22379.41.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1508183166.22379.41.camel@codethink.co.uk> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 16, 2017 at 08:46:06PM +0100, Ben Hutchings wrote: > On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.��If anyone has any objections, please let me > > know. > > > > ------------------ > > > > From: Christophe JAILLET > > > > > > [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ] > > > > 'request_irq()' and 'free_irq()' should be called with the same > > dev_id. > [...] > > This fixes a bug introduced in 4.6 by commit 465893e18878 "tty: > goldfish: support platform_device with id -1". For earlier kernel > versions, it *introduces* a bug. > > Please revert from the 3.18 and 4.4 branches. Ugh, the goldfish drivers are a pain lately... I'll go revert this, luckily no one actually runs them in the tree :) thanks, greg k-h