From: Oleg Nesterov <oleg@redhat.com>
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: Gargi Sharma <gs051095@gmail.com>,
linux-kernel@vger.kernel.org, riel@surriel.com,
julia.lawall@lip6.fr, akpm@linux-foundation.org,
mingo@kernel.org, pasha.tatashin@oracle.com,
ktkhai@virtuozzo.com, ebiederm@xmission.com, hch@infradead.org,
lkp@intel.com, tony.luck@intel.com
Subject: Re: [v6,1/2] pid: Replace pid bitmap implementation with IDR API
Date: Thu, 19 Oct 2017 18:18:00 +0200 [thread overview]
Message-ID: <20171019161800.GA8886@redhat.com> (raw)
In-Reply-To: <20171019073050.GC29091@outlook.office365.com>
On 10/19, Andrei Vagin wrote:
>
> Hi Gargi,
>
> This patch breaks CRIU, because it changes a meaning of ns_last_pid.
...
> > @@ -311,7 +297,7 @@ static int pid_ns_ctl_handler(struct ctl_table *table, int write,
> > * it should synchronize its usage with external means.
> > */
> >
> > - tmp.data = &pid_ns->last_pid;
> > + tmp.data = &pid_ns->idr.idr_next;
Ah, yes, off-by-one error...
Gargi, I don't think you need to make another version, I'd suggest you to send
the trivial fix to Andrew, afaics you just need to replace these 2 lines with
unsigned int last;
int err;
tmp.data = &last;
err = proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
if (!err)
idr_set_cursor(&pid_ns->idr, last + 1);
return err;
Oleg.
next prev parent reply other threads:[~2017-10-19 16:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 22:19 [PATCH v6 0/2] Replacing PID bitmap implementation with IDR API Gargi Sharma
2017-10-11 22:19 ` [PATCH v6 1/2] pid: Replace pid " Gargi Sharma
2017-10-11 22:28 ` Rik van Riel
2017-10-11 22:37 ` Andrew Morton
2017-10-12 0:54 ` Rik van Riel
2017-10-12 22:58 ` Andrew Morton
2017-10-13 14:58 ` Oleg Nesterov
2017-10-19 7:30 ` [v6,1/2] " Andrei Vagin
2017-10-19 13:20 ` Gargi Sharma
2017-10-19 16:18 ` Oleg Nesterov [this message]
2017-10-20 16:06 ` Gargi Sharma
2017-10-20 17:21 ` Andrei Vagin
2017-10-22 8:05 ` Gargi Sharma
2017-10-23 15:31 ` Oleg Nesterov
2017-10-11 22:19 ` [PATCH v6 2/2] pid: Remove pidhash Gargi Sharma
2017-10-11 22:28 ` Rik van Riel
2017-10-11 22:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019161800.GA8886@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@virtuozzo.com \
--cc=ebiederm@xmission.com \
--cc=gs051095@gmail.com \
--cc=hch@infradead.org \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=riel@surriel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.