From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5Dyp-0002Xj-1O for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:47:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5Dyk-0002rz-Tw for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:47:35 -0400 Received: from smtp.citrix.com ([66.165.176.89]:7795) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5Dyk-0002rm-NU for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:47:30 -0400 Date: Thu, 19 Oct 2017 17:47:28 +0100 From: Anthony PERARD Message-ID: <20171019164728.GC11934@perard.uk.xensource.com> References: <1507564902-9000-1-git-send-email-ian.jackson@eu.citrix.com> <1507564902-9000-2-git-send-email-ian.jackson@eu.citrix.com> <23003.41880.818255.728737@mariner.uk.xensource.com> <20171010103215.GD1771@perard.uk.xensource.com> <23016.54514.243025.328812@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <23016.54514.243025.328812@mariner.uk.xensource.com> Subject: Re: [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: qemu-devel@nongnu.org, Ross Lagerwall , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org On Thu, Oct 19, 2017 at 05:38:10PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH 1/8] xen: link against xentoolcore"): > > I don't think it is necessary to do anything in qemu. The linker should > > find on its own the new libxentoolcore as long as an option > > -Wl,-rpath-link= provide the right path to xentoolcore when building > > qemu from xen.git. In other cases, the pkg-config files should be > > enough (configure doesn't need to known about a new xentoolcore.pc > > file). > > It seems that the build still works, without this patch but without > the rest of my series too, because we end up passing > -L/u/iwj/work/xen.git/tools/../tools/libs/toolcore > -Wl,-rpath-link=/u/iwj/work/xen.git/tools/../tools/libs/toolcore > (or similar) on the qemu link line. So when ld links against > libxenstore (say) it finds that xenstore needs toolcore and finds > toolcore in the relevant paths. > > We still need this patch for the rest of the series, though. Of course, I was only arguing that this patch on its own is not usefull. Do you need a signed-off-by or review-by from me? Since it looks like I'm the author. -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 1/8] xen: link against xentoolcore Date: Thu, 19 Oct 2017 17:47:28 +0100 Message-ID: <20171019164728.GC11934@perard.uk.xensource.com> References: <1507564902-9000-1-git-send-email-ian.jackson@eu.citrix.com> <1507564902-9000-2-git-send-email-ian.jackson@eu.citrix.com> <23003.41880.818255.728737@mariner.uk.xensource.com> <20171010103215.GD1771@perard.uk.xensource.com> <23016.54514.243025.328812@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5Dyn-0006hT-3m for xen-devel@lists.xenproject.org; Thu, 19 Oct 2017 16:47:33 +0000 Content-Disposition: inline In-Reply-To: <23016.54514.243025.328812@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ian Jackson Cc: Juergen Gross , Ross Lagerwall , Stefano Stabellini , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBPY3QgMTksIDIwMTcgYXQgMDU6Mzg6MTBQTSArMDEwMCwgSWFuIEphY2tzb24gd3Jv dGU6Cj4gQW50aG9ueSBQRVJBUkQgd3JpdGVzICgiUmU6IFtQQVRDSCAxLzhdIHhlbjogbGluayBh Z2FpbnN0IHhlbnRvb2xjb3JlIik6Cj4gPiBJIGRvbid0IHRoaW5rIGl0IGlzIG5lY2Vzc2FyeSB0 byBkbyBhbnl0aGluZyBpbiBxZW11LiBUaGUgbGlua2VyIHNob3VsZAo+ID4gZmluZCBvbiBpdHMg b3duIHRoZSBuZXcgbGlieGVudG9vbGNvcmUgYXMgbG9uZyBhcyBhbiBvcHRpb24KPiA+IC1XbCwt cnBhdGgtbGluaz0gcHJvdmlkZSB0aGUgcmlnaHQgcGF0aCB0byB4ZW50b29sY29yZSB3aGVuIGJ1 aWxkaW5nCj4gPiBxZW11IGZyb20geGVuLmdpdC4gIEluIG90aGVyIGNhc2VzLCB0aGUgcGtnLWNv bmZpZyBmaWxlcyBzaG91bGQgYmUKPiA+IGVub3VnaCAoY29uZmlndXJlIGRvZXNuJ3QgbmVlZCB0 byBrbm93biBhYm91dCBhIG5ldyB4ZW50b29sY29yZS5wYwo+ID4gZmlsZSkuCj4gCj4gSXQgc2Vl bXMgdGhhdCB0aGUgYnVpbGQgc3RpbGwgd29ya3MsIHdpdGhvdXQgdGhpcyBwYXRjaCBidXQgd2l0 aG91dAo+IHRoZSByZXN0IG9mIG15IHNlcmllcyB0b28sIGJlY2F1c2Ugd2UgZW5kIHVwIHBhc3Np bmcKPiAgIC1ML3UvaXdqL3dvcmsveGVuLmdpdC90b29scy8uLi90b29scy9saWJzL3Rvb2xjb3Jl Cj4gICAtV2wsLXJwYXRoLWxpbms9L3UvaXdqL3dvcmsveGVuLmdpdC90b29scy8uLi90b29scy9s aWJzL3Rvb2xjb3JlCj4gKG9yIHNpbWlsYXIpIG9uIHRoZSBxZW11IGxpbmsgbGluZS4gIFNvIHdo ZW4gbGQgbGlua3MgYWdhaW5zdAo+IGxpYnhlbnN0b3JlIChzYXkpIGl0IGZpbmRzIHRoYXQgeGVu c3RvcmUgbmVlZHMgdG9vbGNvcmUgYW5kIGZpbmRzCj4gdG9vbGNvcmUgaW4gdGhlIHJlbGV2YW50 IHBhdGhzLgo+IAo+IFdlIHN0aWxsIG5lZWQgdGhpcyBwYXRjaCBmb3IgdGhlIHJlc3Qgb2YgdGhl IHNlcmllcywgdGhvdWdoLgoKT2YgY291cnNlLCBJIHdhcyBvbmx5IGFyZ3VpbmcgdGhhdCB0aGlz IHBhdGNoIG9uIGl0cyBvd24gaXMgbm90IHVzZWZ1bGwuCgpEbyB5b3UgbmVlZCBhIHNpZ25lZC1v ZmYtYnkgb3IgcmV2aWV3LWJ5IGZyb20gbWU/IFNpbmNlIGl0IGxvb2tzIGxpa2UKSSdtIHRoZSBh dXRob3IuCgotLSAKQW50aG9ueSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz Lnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=