From: "Michał Winiarski" <michal.winiarski@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 00/14] Preemption with GuC, third attempt
Date: Thu, 19 Oct 2017 20:36:05 +0200 [thread overview]
Message-ID: <20171019183619.6235-1-michal.winiarski@intel.com> (raw)
It turns out that preempt failures were caused by GuC not expecting multiple
workitems when preempt action was requested.
Another thing that deserves attention is the workaround for missing
USER_INTERRUPT. The value I've used for the delayed work timer is just a
semi-educated guess at this point.
There's also small oneline doorbell cleanup (we weren't observing any problems
with it, but Sagar pointed out that doorbell cookie with value 0 seems to be
reserved), and removal of unused variable (pointed out by Michel)
Dave Gordon (1):
drm/i915/guc: Add a second client, to be used for preemption
Michał Winiarski (13):
drm/i915/guc: Do not use 0 for GuC doorbell cookie
drm/i915/guc: Extract GuC stage desc pool creation into a helper
drm/i915/guc: Allocate separate shared data object for GuC
communication
drm/i915/guc: Initialize GuC before restarting engines
drm/i915/guc: Add preemption action to GuC firmware interface
drm/i915/guc: Split guc_wq_item_append
drm/i915: Extract "emit write" part of emit breadcrumb functions
drm/i915: Add information needed to track engine preempt state
drm/i915/guc: Keep request->priority for its lifetime
drm/i915: Rename helpers used for unwinding, use macro for can_preempt
drm/i915/guc: Preemption! With GuC
drm/i915/guc: Workaround the missing user interrupt after preemption
HAX Enable GuC Submission for CI
drivers/gpu/drm/i915/i915_debugfs.c | 11 +-
drivers/gpu/drm/i915/i915_drv.c | 5 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +
drivers/gpu/drm/i915/i915_gem.c | 20 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 +-
drivers/gpu/drm/i915/i915_guc_submission.c | 511 +++++++++++++++++++++++------
drivers/gpu/drm/i915/i915_params.h | 4 +-
drivers/gpu/drm/i915/intel_engine_cs.c | 6 +-
drivers/gpu/drm/i915/intel_guc.c | 14 +-
drivers/gpu/drm/i915/intel_guc.h | 20 +-
drivers/gpu/drm/i915/intel_guc_fwif.h | 40 +++
drivers/gpu/drm/i915/intel_lrc.c | 56 ++--
drivers/gpu/drm/i915/intel_lrc.h | 1 -
drivers/gpu/drm/i915/intel_ringbuffer.h | 53 +++
drivers/gpu/drm/i915/intel_uncore.c | 2 +-
15 files changed, 575 insertions(+), 178 deletions(-)
--
2.13.6
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-10-19 18:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 18:36 Michał Winiarski [this message]
2017-10-19 18:36 ` [PATCH 01/14] drm/i915/guc: Do not use 0 for GuC doorbell cookie Michał Winiarski
2017-10-21 6:28 ` Sagar Arun Kamble
2017-10-19 18:36 ` [PATCH 02/14] drm/i915/guc: Extract GuC stage desc pool creation into a helper Michał Winiarski
2017-10-19 18:36 ` [PATCH v2 03/14] drm/i915/guc: Allocate separate shared data object for GuC communication Michał Winiarski
2017-10-19 18:36 ` [PATCH 04/14] drm/i915/guc: Initialize GuC before restarting engines Michał Winiarski
2017-10-25 18:44 ` Chris Wilson
2017-10-19 18:36 ` [PATCH 05/14] drm/i915/guc: Add preemption action to GuC firmware interface Michał Winiarski
2017-10-19 18:36 ` [PATCH v2 06/14] drm/i915/guc: Add a second client, to be used for preemption Michał Winiarski
2017-10-19 19:36 ` Michal Wajdeczko
2017-10-19 18:36 ` [PATCH 07/14] drm/i915/guc: Split guc_wq_item_append Michał Winiarski
2017-10-19 18:36 ` [PATCH v2 08/14] drm/i915: Extract "emit write" part of emit breadcrumb functions Michał Winiarski
2017-10-19 18:36 ` [PATCH 09/14] drm/i915: Add information needed to track engine preempt state Michał Winiarski
2017-10-19 18:36 ` [PATCH 10/14] drm/i915/guc: Keep request->priority for its lifetime Michał Winiarski
2017-10-19 18:36 ` [PATCH v2 11/14] drm/i915: Rename helpers used for unwinding, use macro for can_preempt Michał Winiarski
2017-10-19 19:18 ` Chris Wilson
2017-10-19 19:20 ` Chris Wilson
2017-10-19 18:36 ` [PATCH v3 12/14] drm/i915/guc: Preemption! With GuC Michał Winiarski
2017-10-19 19:14 ` Chris Wilson
2017-10-19 19:16 ` Chris Wilson
2017-10-20 9:00 ` Chris Wilson
2017-10-20 17:00 ` Chris Wilson
2017-10-23 23:14 ` Daniele Ceraolo Spurio
2017-10-25 18:15 ` Chris Wilson
2017-10-19 18:36 ` [PATCH 13/14] drm/i915/guc: Workaround the missing user interrupt after preemption Michał Winiarski
2017-10-19 19:44 ` Chris Wilson
2017-10-20 17:22 ` Chris Wilson
2017-10-20 17:42 ` Daniele Ceraolo Spurio
2017-10-20 16:08 ` Chris Wilson
2017-10-19 18:36 ` [PATCH 14/14] HAX Enable GuC Submission for CI Michał Winiarski
2017-10-19 19:11 ` ✗ Fi.CI.BAT: failure for Preemption with GuC, third attempt Patchwork
2017-10-26 21:21 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019183619.6235-1-michal.winiarski@intel.com \
--to=michal.winiarski@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.