From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param Date: Thu, 19 Oct 2017 23:43:39 +0200 Message-ID: <20171019214339.GH1978@nanopsycho.orion> References: <1508440630-25830-1-git-send-email-steven.lin1@broadcom.com> <1508440630-25830-6-git-send-email-steven.lin1@broadcom.com> <20171019213955.GG1978@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Steve Lin , "netdev@vger.kernel.org" , Jiri Pirko , "davem@davemloft.net" , "michael.chan@broadcom.com" , "linville@tuxdriver.com" , "gospo@broadcom.com" To: Yuval Mintz Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:55594 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbdJSVnl (ORCPT ); Thu, 19 Oct 2017 17:43:41 -0400 Received: by mail-wm0-f66.google.com with SMTP id u138so19109085wmu.4 for ; Thu, 19 Oct 2017 14:43:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20171019213955.GG1978@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Oct 19, 2017 at 11:39:55PM CEST, jiri@resnulli.us wrote: >Thu, Oct 19, 2017 at 10:32:21PM CEST, yuvalm@mellanox.com wrote: >>> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent >>> config >>> parameter. Defines number of MSI-X vectors allocated per VF. >>> Value is permanent (stored in NVRAM), so becomes the new default >>> value for this device. >> >>Sounds like you're having this enforce the same configuration for all child VFs. > >Yeah, this sounds like per-port config. This opens old but lately silent discussion about introducing new port types for different things. Like VF, dsa CPU port or dsa inter-chip ports. > > >> >>> >>> Signed-off-by: Steve Lin >>> Acked-by: Andy Gospodarek >>> --- >>> include/uapi/linux/devlink.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h >>> index 8ad6c63..ef163b6 100644 >>> --- a/include/uapi/linux/devlink.h >>> +++ b/include/uapi/linux/devlink.h >>> @@ -260,6 +260,7 @@ enum devlink_perm_config_param { >>> DEVLINK_PERM_CONFIG_SRIOV_ENABLED, >>> DEVLINK_PERM_CONFIG_NUM_VF_PER_PF, >>> DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT, >>> + DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF, >>> }; >>> >>> #endif /* _UAPI_LINUX_DEVLINK_H_ */ >>> -- >>> 2.7.4 >>