From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 19 Oct 2017 21:54:25 +0200 Subject: [Buildroot] [RFC, v2, 1/4] package/go: fixing crosscompilation settings In-Reply-To: References: Message-ID: <20171019215425.65df2006@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Thu, 19 Oct 2017 13:20:14 -0400, Christian Stewart wrote: > Tested, works fine. Signing off on the first commit in the series only. > > Signed-off-by: Christian Stewart So, this should be a Tested-by I guess. Signed-off-by is added if you wrote the code or convey the code. Tested-by is if you tested it without necessarily looking at the code/reviewing it, Acked-by if you agree with it (it's a strong statement), Reviewed-by if you reviewed it (it's somewhat weaker than Acked-by). Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com