From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbdJSWfm (ORCPT ); Thu, 19 Oct 2017 18:35:42 -0400 Received: from mail-he1eur01on0094.outbound.protection.outlook.com ([104.47.0.94]:20563 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752808AbdJSWfk (ORCPT ); Thu, 19 Oct 2017 18:35:40 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=avagin@virtuozzo.com; Date: Thu, 19 Oct 2017 15:35:22 -0700 From: Andrei Vagin To: Josh Poimboeuf Cc: Ingo Molnar , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, hpa@zytor.com, tglx@linutronix.de Subject: Re: [2/2] x86/unwind: Make CONFIG_UNWINDER_ORC=y the default in kconfig for 64-bit Message-ID: <20171019223522.GA4499@outlook.office365.com> References: <9b1237bbe7244ed9cdf8db2dcb1253e37e1c341e.1507924831.git.jpoimboe@redhat.com> <20171019165103.GA15123@outlook.office365.com> <20171019181655.7yjgxuebkqzzcz4f@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20171019181655.7yjgxuebkqzzcz4f@treble> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [65.152.152.74] X-ClientProxiedBy: MWHPR22CA0041.namprd22.prod.outlook.com (2603:10b6:300:69::27) To HE1PR08MB0748.eurprd08.prod.outlook.com (2a01:111:e400:59b1::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c88bd038-e5a2-450e-2d5f-08d51741b76d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254172)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199)(201703131423095);SRVR:HE1PR08MB0748; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0748;3:atG5Fm5QNboh7ometbp5+AxsGFoDNqV8krG2Q5zHk7dso1J9cZLPTJrBjuFJrgkLWdEBYG615Ptyo3KCp+/hg1oKEiIGXf0wgn6nfVZVdBNtx7S5DA2qMhqDsD+NStcQMfYL60SeF4dta050zpa7Lab/0Ocx+TKSpaqOPNVipD6y95ycNliXT9Vp5+dy+lZcNl3deHnium26rdaWIhyMV7LpFKhHPwCOm2nw8XXikoXkIxONrS9J0CpbejlnNPFL;25:6TBMvCPOU6DgJFXU8l96QPlA3YJLZ5AS0p3oDnP524EV3CJA+8rvzYLjh8h4DoMYdua4ADoQJFQ1JCRg5k9n+TZrU0nXmOn1LVPCq7E1L7MGceWdbDKONUBgiD5U5lm5UBKWQEzPTkSNQEkiV4pAEQMRWb7KwuprASTfqGmGhQCTdk0hezOxSzf2uRocKEol7W4SJ+XeNxwuYihZ5z/S8fQcyRcnpfZbl8aCnY8rPxaVRIA/90Xv6lkFj9LOzcEUicoWpYdmEIYip3IM4XjECgyqA/xvlOUQF6S9IqOyZm8PFsQhgV/GHOQ9HIm0eupONoloqk/MAgjIohJPk0560OMw54176PdKbKopWNjh//A=;31:h4pVxw2NGdL3IoIhfsTuefXeuOw/iKf7O/MQN2YiTG5okCChzvo2aeB6w8HhIAA1GhfIX17PNb1kTLPNWPBBMRRdygIFMd9q8YHSZ2mleZQZQG6CILUgiJF+CLlFVlVVT/fajmfzaFmLp79l7JtOvx71DPDKXs/n5Zxz70K0muPXpcJ8VpcByxzCDwKqHdX/EUlWAdFJiMgRou4aXPabO6IHeUuzeNLaaccb3BI+AXY= X-MS-TrafficTypeDiagnostic: HE1PR08MB0748: X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0748;20:nP/o6RZd08hP0JU0T4O0PHsZP4Xz10dJGl5Ae6GuQ4cS0PBbRpsY23bg5exOWL7/scB3Xyln9bq7AsZzHGkp8VP5o1YxwkZ3RsQhXIW95Cm0eSQznowfDoPfXoBClNNJZSAWEvdvbRbzvnz2Oxe5h8y/zAGmA3ftvpw8EVwZvcdHVZ3rmbbdhFmaBTS4Ye9AV1s5jr9PzyFdRVQrQa6WHlH3BHk3Hpwhrm0M32sYw5t4di92fbpFqdKitV1hPyGx5QiELWbuaX/Z4Q5A5SX6aBNx09lw+daOcu0jUep3ScZX85LXsgXp0KgwP1Jggu9Qpki9HAh1V0Q7dw5TxnOM2XQzI8Jzk7mq8o5G/V1a+8qbRyFlHTmfO9v/vDJRcjdiZ0k8WHW3ZD0okV8rSN9q5SQ5CzHPDpDYfQy3b8NKa9Y=;4:+T9KB6UWVOHWUFFc1MMKK4rFErg9l3Aoee0zTJWMIzJyzu07a1c3pSgxnTzGwBaDnYghdrBbdKqYNPx20lNMPqnPynmaI+JLkpA6AXsWkvjuMV4TW6d31yFJRumDMOMNePb5LrFaPIxGoOYxhhPuNw6S/rDlXkHRqq0CHl6UN3fl0WVlJsDAwQ32RrNSUSxcZW/zFLM1vJ33B19XM0Two8Ry4oD65qBwuDpKFS8l0Wpf6VGf/3MdL1/uYdaSzyKO X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR08MB0748;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR08MB0748; X-Forefront-PRVS: 0465429B7F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(189002)(24454002)(199003)(2950100002)(8676002)(81156014)(33656002)(6506006)(76176999)(6666003)(6246003)(86362001)(81166006)(4326008)(575784001)(9686003)(6306002)(68736007)(101416001)(189998001)(8936002)(105586002)(106356001)(229853002)(55016002)(7736002)(23686003)(50986999)(53936002)(54356999)(6916009)(966005)(3846002)(53416004)(5660300001)(6116002)(97736004)(1076002)(69596002)(16526018)(316002)(50466002)(47776003)(478600001)(66066001)(58126008)(2906002)(25786009)(16586007)(305945005)(83506002)(18370500001)(505234006);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR08MB0748;H:outlook.office365.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;HE1PR08MB0748;23:2HTbURkdk5liWLC0awzx5pnTGRFkF+3pwTwftp/woJi?= =?koi8-r?Q?I97Uld/tYfyctWk1avCBG4s1qYVJvJPCBoTr5CoPynV40IFKOMZyp1Uif+FH8X?= =?koi8-r?Q?hk/jyxmBIFPe1stP7gvpMh2INcHMxnR9FPef4QujsELOGiBShIZFXEcD5eaYfj?= =?koi8-r?Q?Rcs+XXZ46oGz5NDlwK+vS/2o2pdjJcDEJIRlP6wbt7Ev0ywAgqD/qW14BoUW3S?= =?koi8-r?Q?36SWt6A6iMIwo5vnQKzVskEpVJgAWNdBmcvwMpP+X+vMPomEuMQouRVbmNvrGQ?= =?koi8-r?Q?sEHu6rTJDdfDkNsn4T7zkM6JQFitsN7/UQOZDQDOHm3fo8U3dwUd0vT7fzXJiT?= =?koi8-r?Q?GVeNQYZgwjauiEfCa0siqxZxWxhghYuQG87crVMZdQ6V/PVTpjK9Q+9ge0iMyR?= =?koi8-r?Q?CjcgdQadQzKFAyx8vkAni43wpUvKOJqj+WCuym75/0dwkJL70MiDKb+DsRUf97?= =?koi8-r?Q?RxFuREtCIztRhnXz7YmVIzwHBVNWFXFt7qjuMi9TLXgABOWWrmXYy0KxAJi9ea?= =?koi8-r?Q?/ZSCDIiG8NTSdnNambvD/QCiycwPV6Bi4e3q3uGTIaJKUPC0oEfJhpspnjyVwy?= =?koi8-r?Q?ArmcnH+bRmbOYy9024CN48F3LYytmrM+IFQ8j+ftHPHNxNaokUwDZ/kwWksZn2?= =?koi8-r?Q?E1rt51ft+yIhQJbeWM++Khn7i/yk+qbpPrHihej2Uw43fbFZtGML+WirGMA8/p?= =?koi8-r?Q?fTKA05HyYZOk8+1BPGV0VU0cmqs4hpiE5Xr/bPSQ/DdNkURpOo7SxeYvbzsVUp?= =?koi8-r?Q?bheaKqGoqcyRP5bvbEuPO/4nIRDHbrckVm0bcrr/P3cs01B/tdQEJyUee3IYZd?= =?koi8-r?Q?zV+44u33s+kJ2VV0Obpj020zEHwBeF3HBijjqENd0sBRNJYTYCnRq8qQ4caYRd?= =?koi8-r?Q?mha2AMT/HqZLukJKL6yF2vPvVGNKJPZeRv0vSSFVb7DOk+p4wjX1024Ud7pIwT?= =?koi8-r?Q?GFjTTpYW1Dc2NUuZhvfwQp7D/muLzqb9u0IG5P1vfHVORYHAbZZSD4De4fhJBI?= =?koi8-r?Q?UMieREFWsQImFcS0/KQDKPstrNVpNhnxB99RpxMu4rQz0KP2XI2EUj4P/yAq3q?= =?koi8-r?Q?jdN5VORWhTs5HuROB34v9VfJGAKPKwduZGbHN1tybqGihtssMeVHVEuQRMGWN/?= =?koi8-r?Q?/mCGaIvfaeoI4108fhV6tSHzQmRYTQf+k3iwYLdfpdk6rXfPmYjQ/67xr+GZab?= =?koi8-r?Q?FcuhN/TBLXqyx5efYruhAT/d47OZNO/bOyQf6KN4o/Nk+DKUgp7bTO43ig7wEm?= =?koi8-r?Q?trV0d8fjWHZ/L/G4HAA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0748;6:NFSqP93yWcDiVnzGycLT9hJrQe5tyaVgER+pJ0k2p0JRYWPBJpVMsFeQkcQmq8JXSQuqFwqnOxDCKsxGxsM58jlRN13VroeyCn4m0+JezAQQ9CQsdAv5MUUjTHw0Qw/XLs+7kiqty7r6t2dInnKz3vo5s05gcSGiiSFmatBskywkchvbQb8ZfYry+DbCq+EXB55ioN9JvTdMk2R+pAL0JP3hk+0JTRq/nKwijnZ16gxFNgut6SDdQJKjdpRBmvzCQe/4HJb4h36vW5iI4Nmd7gz2NS2w5N4u6pKedgAi6wx6fKDrz/Cg+J3hV7Di2kKATPskf+8jcq6SfT4oMVgypw==;5:UfJj9WmoZpTEsbtZfal4Clw2ZDTn7YN/oV5NEh/MuMTcDxUgezQjbjmLQYWMb87vk6UgFuZ7B7rTE2kn6Guerwvz4F4/noq3hb3t9ZhznbrICmgjr76IWeS/LD/ep8rNABakMIgNVb6Am9gOR09UZA==;24:l6MT1+8e8n/2x8MJdwT4ScBQyC7JmGFxDx7qBzKGYZIVgCp92A67Q8M57iUKoysKbH+Lm4d4Jkj5ChtEsVD4WCUHFJ16DI1AMaCa0KEvKNA=;7:iK68Cn9bzGQ57raJlloN6OpFOE30qJ/HD1v6axwpILhhXNs9eUNAZVMlaQPirb39t7trcFjJ2xI5iGM7TpC0FT6SXisMhpc7iYbmsUFnG9Emrkc/plrHX4lKN2FTT3cyj1KLniLGQQ/qBHe9IN7AxBQlWgunI4Nsyy3BuD+oPkPMZCo3mtf9KJl0xLiIxLPQruFR6EV3soCulDHwp8N6/YPiFNUqEhSeA9FnLL+F0TM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0748;20:GSDB2aRqfXUvGEwZAUsrccJGTh9ZkjHEmz/zpMALD+NurlQJ6/CIBzRbuHcNQQS7vOGBCHYlmNkPY1huxXTnrkQBVGs21yG839+/5I/1yMDOS+v14ZCu2RWus+DKnPKgcBm9iW6GwzwoctbrCnv/a5IwsWnasIhN9vj2m+e1/vM= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2017 22:35:34.3928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0748 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2017 at 01:16:55PM -0500, Josh Poimboeuf wrote: > On Thu, Oct 19, 2017 at 09:51:04AM -0700, Andrei Vagin wrote: > > Hi, > > > > We run CRIU tests for tip/auto-latest regularly, and a few days ago our > > test job started to detect this warning in a kernel log: > > > > [ 44.235786] WARNING: can't dereference iret registers at ffff8801c5f17fe0 for ip ffffffff95f0d94b > > > > What does it mean? How critical is it? > > > > Our test job fails if it detects any warning in a kernel log. Maybe we > > need to investigate reasons of this warning and try to eliminate it? > > > > Here are logs: > > https://travis-ci.org/avagin/linux/jobs/289676634 > > I think it means the unwinder found some bad ORC unwinder metadata. Any > chance you have access to the kernel binary? I need to know what code > corresponds to that ffffffff95f0d94b address. > > Or if you can reproduce with the following patch, that should help: > > > diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c > index 570b70d3f604..95b633f0ce51 100644 > --- a/arch/x86/kernel/unwind_orc.c > +++ b/arch/x86/kernel/unwind_orc.c > @@ -448,7 +448,7 @@ bool unwind_next_frame(struct unwind_state *state) > > case ORC_TYPE_REGS_IRET: > if (!deref_stack_regs(state, sp, &state->ip, &state->sp, false)) { > - orc_warn("can't dereference iret registers at %p for ip %p\n", > + orc_warn("can't dereference iret registers at %p for ip %pB\n", > (void *)sp, (void *)orig_ip); > goto done; > } I applied your patch and rerun tests. [ 44.947699] WARNING: can't dereference iret registers at ffff880178f5ffe0 for ip int3+0x5b/0x60 and now here is a warning from kasan: [ 477.775676] ================================================================== [ 477.775845] BUG: KASAN: stack-out-of-bounds in deref_stack_reg+0x11d/0x150 [ 477.775952] Read of size 8 at addr ffff880166b7fe90 by task make/16028 [ 477.776055] [ 477.776149] CPU: 0 PID: 16028 Comm: make Not tainted 4.14.0-rc5+ #1 [ 477.776152] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 [ 477.776155] Call Trace: [ 477.776159] [ 477.776167] dump_stack+0x5c/0x7e [ 477.776175] print_address_description+0x6b/0x290 [ 477.776182] ? deref_stack_reg+0x11d/0x150 [ 477.776186] kasan_report+0x25d/0x340 [ 477.776194] deref_stack_reg+0x11d/0x150 [ 477.776201] ? __read_once_size_nocheck.constprop.6+0x10/0x10 [ 477.776206] ? get_stack_info+0x37/0x170 [ 477.776212] ? stack_access_ok+0xdc/0x150 [ 477.776221] unwind_next_frame+0xe35/0x1c10 [ 477.776230] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776238] ? deref_stack_reg+0x150/0x150 [ 477.776247] ? is_bpf_text_address+0x54/0x60 [ 477.776253] ? kernel_text_address+0xf4/0x100 [ 477.776257] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776266] __save_stack_trace+0x73/0xd0 [ 477.776277] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776285] save_stack+0x33/0xb0 [ 477.776291] ? kasan_slab_free+0x70/0xc0 [ 477.776298] ? kmem_cache_free+0x9f/0x230 [ 477.776303] ? rcu_process_callbacks+0x451/0xd60 [ 477.776307] ? __do_softirq+0x1d3/0x5e0 [ 477.776312] ? irq_exit+0x146/0x170 [ 477.776322] ? smp_apic_timer_interrupt+0x13e/0x3b0 [ 477.776326] ? apic_timer_interrupt+0x8c/0xa0 [ 477.776331] ? lock_acquire+0x6b/0x260 [ 477.776336] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776347] ? update_curr+0x2d6/0x600 [ 477.776354] ? posix_cpu_timers_exit_group+0x50/0x50 [ 477.776365] ? trigger_load_balance+0x1fd/0x8a0 [ 477.776374] ? note_gp_changes+0x14e/0x1b0 [ 477.776384] ? lock_downgrade+0x590/0x590 [ 477.776389] ? rcu_accelerate_cbs+0x106/0x5e0 [ 477.776398] ? lock_acquire+0x113/0x260 [ 477.776402] ? rcu_process_callbacks+0x407/0xd60 [ 477.776407] kasan_slab_free+0x70/0xc0 [ 477.776414] ? rcu_process_callbacks+0x451/0xd60 [ 477.776418] kmem_cache_free+0x9f/0x230 [ 477.776425] ? free_inode_nonrcu+0x20/0x20 [ 477.776430] rcu_process_callbacks+0x451/0xd60 [ 477.776443] ? note_gp_changes+0x1b0/0x1b0 [ 477.776451] ? native_apic_msr_write+0x27/0x30 [ 477.776456] ? lapic_next_event+0x55/0x80 [ 477.776465] __do_softirq+0x1d3/0x5e0 [ 477.776479] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776483] irq_exit+0x146/0x170 [ 477.776487] smp_apic_timer_interrupt+0x13e/0x3b0 [ 477.776494] apic_timer_interrupt+0x8c/0xa0 [ 477.776497] [ 477.776502] RIP: 0010:lock_acquire+0x6b/0x260 [ 477.776505] RSP: 0018:ffff880166b7fd48 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff11 [ 477.776512] RAX: 0000000000000007 RBX: ffff8801c91cb080 RCX: 0000000000000000 [ 477.776515] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8801c91cb8b4 [ 477.776518] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000 [ 477.776521] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 [ 477.776524] R13: 0000000000000000 R14: 0000000000000000 R15: ffffffff9f651fce [ 477.776528] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776552] do_execveat_common.isra.34+0x78e/0x1890 [ 477.776559] ? fs_reclaim_acquire.part.71+0x29/0x30 [ 477.776564] ? fs_reclaim_acquire.part.71+0x5/0x30 [ 477.776569] ? kmem_cache_alloc+0x29/0x1f0 [ 477.776577] ? do_execveat_common.isra.34+0x78e/0x1890 [ 477.776589] ? strncpy_from_user+0x74/0x260 [ 477.776595] ? prepare_bprm_creds+0x100/0x100 [ 477.776599] ? kmem_cache_alloc+0x18d/0x1f0 [ 477.776607] ? getname_flags+0xff/0x500 [ 477.776615] ? SyS_execve+0x2c/0x40 [ 477.776623] ? ptregs_sys_vfork+0x10/0x10 [ 477.776628] ? do_syscall_64+0x181/0x450 [ 477.776638] ? entry_SYSCALL64_slow_path+0x25/0x25 [ 477.776653] [ 477.776747] The buggy address belongs to the page: [ 477.776849] page:ffffea00059adfc0 count:0 mapcount:0 mapping: (null) index:0x0 [ 477.776968] flags: 0x17fff8000000000() [ 477.777067] raw: 017fff8000000000 0000000000000000 0000000000000000 00000000ffffffff [ 477.777184] raw: 0000000000000000 dead000000000200 0000000000000000 0000000000000000 [ 477.777298] page dumped because: kasan: bad access detected [ 477.777404] [ 477.777494] Memory state around the buggy address: [ 477.777594] ffff880166b7fd80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 477.777709] ffff880166b7fe00: 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 [ 477.777823] >ffff880166b7fe80: f4 f4 f4 f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 [ 477.777937] ^ [ 477.778034] ffff880166b7ff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 477.778147] ffff880166b7ff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 477.778260] ================================================================== [ 477.778376] Disabling lock debugging due to kernel taint All logs are here https://travis-ci.org/avagin/linux/jobs/290190646 Unfortunately vmlinux was not saved for this run. Thanks.