All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own
Date: Fri, 20 Oct 2017 12:15:26 +0100	[thread overview]
Message-ID: <20171020111526.olmsxissglp5tptm@citrix.com> (raw)
In-Reply-To: <23017.55292.44476.472798@mariner.uk.xensource.com>

On Fri, Oct 20, 2017 at 12:03:24PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own"):
> > The original extra= was not removed, so there were two extra= in the
> > resulting config file.
> 
> What is the original extra= ?  Why should we not combine them ?

The original extra= is generated by xen-create-image. It has the content
"elevator=noop". It doesn't seem too useful to me. But I'm fine with
combination them.

> 
> > It wasn't a problem for xl because the second extra= took precedence.
> > However libvirt tests would only pick up the first extra= --  they
> > worked by chance.
> 
> That's odd.  Is this to do with the xl -> libxl config converter ?
> It seems to me that that converter should interpret xl config files
> the same way xl does.  (Also xm did the same: last setting wins.)
> 

Yes, the converter only picks up the first.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-10-20 11:15 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 10:38 [OSSTEST PATCH 00/16] Upgrade to Stretch Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 01/16] XXX add a stretch config based on production-config Wei Liu
2017-10-20 10:54   ` Ian Jackson
2017-10-20 11:17     ` Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 02/16] gitignore: ignore vim swap file Wei Liu
2017-10-20 10:53   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 03/16] ts-xen-build-prep: don't install w3c-dtd-xhtml for Stretch onward Wei Liu
2017-10-20 10:50   ` Ian Jackson
2017-10-20 11:37     ` Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 04/16] ts-xen-build-prep: install packages for stretch Wei Liu
2017-10-20 10:50   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 05/16] mg-debian-installer-update-all: put quotes around arguments Wei Liu
2017-10-20 10:56   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 06/16] ts-xen-install: install some packages on stretch Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 07/16] Debian.pm: use sysvinit-core " Wei Liu
2017-10-20 10:57   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 08/16] ts-leak-check: suppress systemd-shim, which leaks in stretch Wei Liu
2017-10-20 10:58   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 09/16] ts-host-install: don't use the new nic naming scheme Wei Liu
2017-10-20 10:58   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own Wei Liu
2017-10-20 11:03   ` Ian Jackson
2017-10-20 11:15     ` Wei Liu [this message]
2017-10-20 12:52       ` Ian Jackson
2017-10-20 13:09         ` Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device Wei Liu
2017-10-20 11:05   ` Ian Jackson
2017-10-20 11:14     ` Wei Liu
2017-10-20 12:35       ` Ian Jackson
2017-10-20 13:17         ` Wei Liu
2017-10-20 13:20           ` Ian Jackson
2017-10-20 13:36             ` Wei Liu
2017-10-20 13:42               ` Ian Jackson
2017-10-20 14:56                 ` Wei Liu
2017-10-20 15:10                   ` Ian Jackson
2017-10-20 15:36                     ` Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 12/16] make-flight: don't test pvgrub for Xen XXX Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 13/16] ts-debian-hvm-install: disable new nic naming scheme Wei Liu
2017-10-20 11:01   ` Ian Jackson
2017-10-20 10:38 ` [OSSTEST PATCH 14/16] ts-xen-build-prep: install e2fslibs-dev Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 15/16] TestSupport: add dpkg option when installing packages Wei Liu
2017-10-20 10:38 ` [OSSTEST PATCH 16/16] ts-guests-nbd-mirror: make it work with stretch Wei Liu
2017-10-20 11:09   ` Ian Jackson
2017-10-20 11:24     ` Wei Liu
2017-10-20 11:31       ` Wei Liu
2017-10-25 13:41 ` [OSSTEST PATCH 00/16] Upgrade to Stretch Wei Liu
2017-10-25 16:36 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171020111526.olmsxissglp5tptm@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.