* [PATCH] HAX: ignore fbcon entirely. ;D
@ 2017-10-20 15:05 Maarten Lankhorst
2017-10-20 15:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2017-10-20 15:05 UTC (permalink / raw)
To: intel-gfx
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 5cf54555da41..d1fdc32f3ff7 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -43,7 +43,7 @@
#include "drm_crtc_helper_internal.h"
-static bool drm_fbdev_emulation = true;
+static bool drm_fbdev_emulation;
module_param_named(fbdev_emulation, drm_fbdev_emulation, bool, 0600);
MODULE_PARM_DESC(fbdev_emulation,
"Enable legacy fbdev emulation [default=true]");
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for HAX: ignore fbcon entirely. ;D
2017-10-20 15:05 [PATCH] HAX: ignore fbcon entirely. ;D Maarten Lankhorst
@ 2017-10-20 15:24 ` Patchwork
2017-10-20 17:45 ` ✗ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-20 15:24 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: HAX: ignore fbcon entirely. ;D
URL : https://patchwork.freedesktop.org/series/32367/
State : failure
== Summary ==
Series 32367v1 HAX: ignore fbcon entirely. ;D
https://patchwork.freedesktop.org/api/1.0/series/32367/revisions/1/mbox/
Test chamelium:
Subgroup hdmi-crc-fast:
pass -> FAIL (fi-skl-6700k) fdo#103019
Subgroup common-hpd-after-suspend:
pass -> DMESG-WARN (fi-skl-6700k)
dmesg-warn -> PASS (fi-kbl-7500u) fdo#102505
Test debugfs_test:
Subgroup read_all_entries:
pass -> DMESG-WARN (fi-ilk-650)
pass -> DMESG-WARN (fi-skl-6770hq)
Test drv_getparams_basic:
Subgroup basic-eu-total:
pass -> INCOMPLETE (fi-cfl-s)
Test gem_ctx_create:
Subgroup basic-files:
pass -> INCOMPLETE (fi-skl-6700k)
Test gem_exec_basic:
Subgroup gtt-render:
pass -> INCOMPLETE (fi-skl-6700hq)
Test gem_exec_nop:
Subgroup basic-series:
pass -> INCOMPLETE (fi-bxt-j4205)
Test gem_exec_reloc:
Subgroup basic-write-gtt-noreloc:
pass -> INCOMPLETE (fi-kbl-r)
Subgroup basic-write-read-noreloc:
pass -> INCOMPLETE (fi-kbl-7560u)
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-byt-j1900)
pass -> DMESG-WARN (fi-byt-n2820)
Test gem_ringfill:
Subgroup basic-default-hang:
dmesg-warn -> PASS (fi-blb-e6850) fdo#101600 +1
Test gem_sync:
Subgroup basic-each:
pass -> INCOMPLETE (fi-glk-1)
Test kms_addfb_basic:
Subgroup unused-modifier:
pass -> INCOMPLETE (fi-kbl-7567u)
Test kms_busy:
Subgroup basic-flip-b:
pass -> INCOMPLETE (fi-skl-6260u)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-j1900) fdo#101705 +1
Test drv_module_reload:
Subgroup basic-reload:
dmesg-warn -> PASS (fi-gdg-551) fdo#102707
fdo#103019 https://bugs.freedesktop.org/show_bug.cgi?id=103019
fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:432s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:433s
fi-blb-e6850 total:289 pass:224 dwarn:0 dfail:0 fail:0 skip:65 time:359s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:551s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:243s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:510s
fi-bxt-j4205 total:77 pass:60 dwarn:0 dfail:0 fail:0 skip:16
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:496s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:487s
fi-cfl-s total:13 pass:3 dwarn:0 dfail:0 fail:0 skip:9
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:398s
fi-gdg-551 total:289 pass:179 dwarn:0 dfail:0 fail:1 skip:109 time:234s
fi-glk-1 total:158 pass:135 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:430s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:420s
fi-ilk-650 total:289 pass:227 dwarn:1 dfail:0 fail:0 skip:61 time:418s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:451s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:447s
fi-kbl-7500u total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:471s
fi-kbl-7560u total:98 pass:85 dwarn:0 dfail:0 fail:0 skip:12
fi-kbl-7567u total:203 pass:190 dwarn:0 dfail:0 fail:0 skip:12
fi-kbl-r total:97 pass:78 dwarn:0 dfail:0 fail:0 skip:18
fi-pnv-d510 total:289 pass:223 dwarn:0 dfail:0 fail:0 skip:66 time:517s
fi-skl-6260u total:207 pass:194 dwarn:0 dfail:0 fail:0 skip:12
fi-skl-6700hq total:45 pass:31 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700k total:27 pass:19 dwarn:1 dfail:0 fail:1 skip:5
fi-skl-6770hq total:289 pass:268 dwarn:1 dfail:0 fail:0 skip:20 time:495s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:447s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:513s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:402s
75b85b0dce2faee585046d3ce19d76bcb163c3e7 drm-tip: 2017y-10m-20d-10h-07m-16s UTC integration manifest
29281f0e5115 HAX: ignore fbcon entirely. ;D
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6125/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: failure for HAX: ignore fbcon entirely. ;D
2017-10-20 15:05 [PATCH] HAX: ignore fbcon entirely. ;D Maarten Lankhorst
2017-10-20 15:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-10-20 17:45 ` Patchwork
2017-10-21 13:10 ` ✗ Fi.CI.BAT: " Patchwork
2017-10-21 14:27 ` ✗ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-20 17:45 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: HAX: ignore fbcon entirely. ;D
URL : https://patchwork.freedesktop.org/series/32367/
State : failure
== Summary ==
Test kms_busy:
Subgroup extended-modeset-hang-newfb-with-reset-render-B:
dmesg-warn -> PASS (shard-hsw) fdo#103038
Subgroup extended-modeset-hang-oldfb-with-reset-render-B:
dmesg-warn -> PASS (shard-hsw) fdo#102249 +2
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-A-planes:
pass -> SKIP (shard-hsw)
Subgroup plane-position-hole-pipe-A-planes:
skip -> PASS (shard-hsw)
Subgroup plane-panning-bottom-right-suspend-pipe-C-planes:
pass -> INCOMPLETE (shard-hsw)
Test gem_userptr_blits:
Subgroup map-fixed-invalidate-overlap-gup:
pass -> INCOMPLETE (shard-hsw)
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> SKIP (shard-hsw)
Subgroup system-suspend-modeset:
pass -> SKIP (shard-hsw)
Test kms_chv_cursor_fail:
Subgroup pipe-C-64x64-right-edge:
pass -> INCOMPLETE (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
pass -> SKIP (shard-hsw) fdo#102614 +1
Subgroup fbc-1p-shrfb-fliptrack:
pass -> SKIP (shard-hsw)
Subgroup fbc-1p-primscrn-spr-indfb-fullscreen:
pass -> FAIL (shard-hsw)
Subgroup fbc-1p-primscrn-pri-shrfb-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-rgb101010-draw-render:
pass -> SKIP (shard-hsw)
Subgroup fbc-1p-primscrn-cur-indfb-move:
skip -> PASS (shard-hsw)
Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
skip -> PASS (shard-hsw)
Test kms_atomic:
Subgroup test_only:
pass -> SKIP (shard-hsw)
Subgroup plane_cursor_legacy:
pass -> SKIP (shard-hsw)
Subgroup atomic_invalid_params:
pass -> SKIP (shard-hsw)
Subgroup plane_overlay_legacy:
pass -> SKIP (shard-hsw)
Subgroup plane_invalid_params:
pass -> SKIP (shard-hsw)
Subgroup crtc_invalid_params:
pass -> SKIP (shard-hsw)
Subgroup plane_invalid_params_fence:
pass -> SKIP (shard-hsw)
Test kms_plane_lowres:
Subgroup pipe-A-tiling-x:
pass -> SKIP (shard-hsw)
Subgroup pipe-A-tiling-none:
pass -> SKIP (shard-hsw)
Test kms_draw_crc:
Subgroup draw-method-rgb565-mmap-gtt-untiled:
pass -> SKIP (shard-hsw)
Test gem_eio:
Subgroup in-flight-suspend:
pass -> FAIL (shard-hsw)
Test kms_sysfs_edid_timing:
pass -> FAIL (shard-hsw) fdo#100047
Test gem_mmap_wc:
Subgroup set-cache-level:
pass -> SKIP (shard-hsw)
fdo#103038 https://bugs.freedesktop.org/show_bug.cgi?id=103038
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-hsw total:2352 pass:1309 dwarn:3 dfail:0 fail:11 skip:1026 time:8614s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6125/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for HAX: ignore fbcon entirely. ;D
2017-10-20 15:05 [PATCH] HAX: ignore fbcon entirely. ;D Maarten Lankhorst
2017-10-20 15:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-20 17:45 ` ✗ Fi.CI.IGT: " Patchwork
@ 2017-10-21 13:10 ` Patchwork
2017-10-21 14:27 ` ✗ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-21 13:10 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: HAX: ignore fbcon entirely. ;D
URL : https://patchwork.freedesktop.org/series/32367/
State : failure
== Summary ==
Series 32367v1 HAX: ignore fbcon entirely. ;D
https://patchwork.freedesktop.org/api/1.0/series/32367/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Subgroup hdmi-crc-fast:
pass -> DMESG-WARN (fi-skl-6700k) fdo#103019
Subgroup common-hpd-after-suspend:
dmesg-warn -> PASS (fi-kbl-7500u) fdo#102505
Test debugfs_test:
Subgroup read_all_entries:
pass -> DMESG-WARN (fi-ilk-650)
Test gem_exec_basic:
Subgroup readonly-bsd1:
pass -> INCOMPLETE (fi-skl-6770hq)
Test gem_exec_parallel:
Subgroup basic:
pass -> INCOMPLETE (fi-bxt-dsi)
Test gem_exec_store:
Subgroup basic-bsd2:
pass -> INCOMPLETE (fi-kbl-7567u)
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-cfl-s) fdo#103186
Test gem_ringfill:
Subgroup basic-default-hang:
dmesg-warn -> PASS (fi-blb-e6850) fdo#101600 +1
Test kms_addfb_basic:
Subgroup bad-pitch-999:
pass -> INCOMPLETE (fi-skl-6260u)
Subgroup no-handle:
pass -> INCOMPLETE (fi-kbl-r)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
pass -> FAIL (fi-gdg-551) fdo#102618
Subgroup basic-flip-after-cursor-atomic:
pass -> INCOMPLETE (fi-glk-1)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a-frame-sequence:
pass -> INCOMPLETE (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-a:
pass -> DMESG-WARN (fi-byt-n2820)
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-n2820) fdo#101705
Test drv_module_reload:
Subgroup basic-reload:
dmesg-warn -> PASS (fi-gdg-551) fdo#102707
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#103019 https://bugs.freedesktop.org/show_bug.cgi?id=103019
fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505
fdo#103186 https://bugs.freedesktop.org/show_bug.cgi?id=103186
fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#102618 https://bugs.freedesktop.org/show_bug.cgi?id=102618
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:431s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:438s
fi-blb-e6850 total:289 pass:224 dwarn:0 dfail:0 fail:0 skip:65 time:357s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:542s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:245s
fi-bxt-dsi total:78 pass:60 dwarn:0 dfail:0 fail:0 skip:17
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:495s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:476s
fi-cfl-s total:289 pass:254 dwarn:3 dfail:0 fail:0 skip:32 time:547s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:400s
fi-gdg-551 total:289 pass:178 dwarn:0 dfail:0 fail:2 skip:109 time:242s
fi-glk-1 total:211 pass:188 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:434s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:419s
fi-ilk-650 total:289 pass:227 dwarn:1 dfail:0 fail:0 skip:61 time:414s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:447s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:447s
fi-kbl-7500u total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:471s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:531s
fi-kbl-7567u total:113 pass:100 dwarn:0 dfail:0 fail:0 skip:12
fi-kbl-r total:196 pass:175 dwarn:0 dfail:0 fail:0 skip:20
fi-pnv-d510 total:289 pass:223 dwarn:0 dfail:0 fail:0 skip:66 time:521s
fi-skl-6260u total:184 pass:171 dwarn:0 dfail:0 fail:0 skip:12
fi-skl-6700hq total:234 pass:209 dwarn:0 dfail:0 fail:0 skip:24
fi-skl-6700k total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:519s
fi-skl-6770hq total:49 pass:39 dwarn:0 dfail:0 fail:0 skip:9
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:453s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:516s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:403s
fi-bxt-j4205 failed to connect after reboot
fcd4cd0d6182714b9ab0b5bb9139a06e6378b8ce drm-tip: 2017y-10m-20d-23h-22m-54s UTC integration manifest
27fc5a3a7a44 HAX: ignore fbcon entirely. ;D
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6135/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: failure for HAX: ignore fbcon entirely. ;D
2017-10-20 15:05 [PATCH] HAX: ignore fbcon entirely. ;D Maarten Lankhorst
` (2 preceding siblings ...)
2017-10-21 13:10 ` ✗ Fi.CI.BAT: " Patchwork
@ 2017-10-21 14:27 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-21 14:27 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: HAX: ignore fbcon entirely. ;D
URL : https://patchwork.freedesktop.org/series/32367/
State : failure
== Summary ==
Test kms_plane_multiple:
Subgroup atomic-pipe-C-tiling-none:
pass -> INCOMPLETE (shard-hsw)
Test pm_rpm:
Subgroup pm-tiling:
pass -> SKIP (shard-hsw)
Test kms_plane_lowres:
Subgroup pipe-A-tiling-x:
pass -> SKIP (shard-hsw)
Subgroup pipe-A-tiling-none:
pass -> SKIP (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-spr-indfb-draw-pwrite:
pass -> SKIP (shard-hsw)
Subgroup fbc-1p-primscrn-spr-indfb-fullscreen:
pass -> FAIL (shard-hsw)
Test gem_userptr_blits:
Subgroup map-fixed-invalidate-gup:
pass -> INCOMPLETE (shard-hsw)
Test gem_eio:
Subgroup in-flight:
pass -> FAIL (shard-hsw)
Subgroup in-flight-contexts:
pass -> FAIL (shard-hsw)
Test kms_sysfs_edid_timing:
pass -> FAIL (shard-hsw) fdo#100047
Test gem_mmap_wc:
Subgroup set-cache-level:
pass -> SKIP (shard-hsw)
Test kms_busy:
Subgroup extended-modeset-hang-oldfb-with-reset-render-A:
dmesg-warn -> PASS (shard-hsw) fdo#102249
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
shard-hsw total:2426 pass:1347 dwarn:1 dfail:0 fail:13 skip:1063 time:8638s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6135/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-21 14:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 15:05 [PATCH] HAX: ignore fbcon entirely. ;D Maarten Lankhorst
2017-10-20 15:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-20 17:45 ` ✗ Fi.CI.IGT: " Patchwork
2017-10-21 13:10 ` ✗ Fi.CI.BAT: " Patchwork
2017-10-21 14:27 ` ✗ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.