From: Peter Zijlstra <peterz@infradead.org>
To: torvalds@linux-foundation.org, akpm@linux-foundation.org
Cc: dave@stgolabs.net, aksgarg1989@gmail.com, tglx@linutronix.de,
mingo@kernel.org, will.deacon@arm.com, joe@perches.com,
peterz@infradead.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, mawilcox@microsoft.com,
keescook@chromium.org, md@google.com
Subject: [PATCH -v2 3/3] lib/int_sqrt: Adjust comments
Date: Fri, 20 Oct 2017 18:44:40 +0200 [thread overview]
Message-ID: <20171020164645.001652117@infradead.org> (raw)
In-Reply-To: 20171020164437.917622646@infradead.org
[-- Attachment #1: peterz-int_sqrt-opt-3.patch --]
[-- Type: text/plain, Size: 638 bytes --]
Our current int_sqrt() is not rough nor any approximation; it
calculates the exact value of: floor(sqrt()). Document this.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
lib/int_sqrt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/lib/int_sqrt.c
+++ b/lib/int_sqrt.c
@@ -10,10 +10,10 @@
#include <linux/bitops.h>
/**
- * int_sqrt - rough approximation to sqrt
+ * int_sqrt - computes the integer square root
* @x: integer of which to calculate the sqrt
*
- * A very rough approximation to the sqrt() function.
+ * Computes: floor(sqrt(x))
*/
unsigned long int_sqrt(unsigned long x)
{
next prev parent reply other threads:[~2017-10-20 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 16:44 [PATCH -v2 0/3] lib/int_sqrt: Fix optimize and document Peter Zijlstra
2017-10-20 16:44 ` [PATCH -v2 1/3] lib/int_sqrt: Optimize small argument Peter Zijlstra
2017-10-20 16:44 ` [PATCH -v2 2/3] lib/int_sqrt: Optimize initial value compute Peter Zijlstra
2017-10-20 16:44 ` Peter Zijlstra [this message]
2017-10-20 19:31 ` [PATCH -v2 0/3] lib/int_sqrt: Fix optimize and document Linus Torvalds
2017-11-02 16:43 ` Joe Perches
2017-11-02 16:47 ` Peter Zijlstra
2017-11-02 16:51 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020164645.001652117@infradead.org \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aksgarg1989@gmail.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=md@google.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.