From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbdJUA5b (ORCPT ); Fri, 20 Oct 2017 20:57:31 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45996 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbdJUA53 (ORCPT ); Fri, 20 Oct 2017 20:57:29 -0400 Date: Sat, 21 Oct 2017 01:57:26 +0100 (WEST) Message-Id: <20171021.015726.910376579423539079.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, gwshan@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 5/5] net/ncsi: Fix length of GVI response packet From: David Miller In-Reply-To: <20171019024309.13628-5-sam@mendozajonas.com> References: <20171019024309.13628-1-sam@mendozajonas.com> <20171019024309.13628-5-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Oct 2017 17:57:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:09 +1100 > From: Gavin Shan > > The length of GVI (GetVersionInfo) response packet should be 40 instead > of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. > > # ethtool --ncsi eth0 swstats > : > RESPONSE OK TIMEOUT ERROR > ======================================= > GVI 0 0 2 > > With this applied, no error reported on GVI response packets: > > # ethtool --ncsi eth0 swstats > : > RESPONSE OK TIMEOUT ERROR > ======================================= > GVI 2 0 0 > > Signed-off-by: Gavin Shan > Signed-off-by: Samuel Mendoza-Jonas Applied.