From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4 net] tcp/dccp: fix ireq->opt races
Date: Sat, 21 Oct 2017 02:18:44 +0100 (WEST) [thread overview]
Message-ID: <20171021.021844.13388346477680130.davem@davemloft.net> (raw)
In-Reply-To: <1508515453.30291.12.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 20 Oct 2017 09:04:13 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> syzkaller found another bug in DCCP/TCP stacks [1]
>
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> ireq->opt unless we own the request sock.
>
> Note the opt field is renamed to ireq_opt to ease grep games.
>
...
> Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> v4: Added the needed changes in net/ipv4/cipso_ipv4.c (and full build)
> v3: fixed the white space mangling
> v2: removed some lines from KASAN report that confuse patchwork.
Hey it compiles! :-)
Applied and queued up for -stable.
next prev parent reply other threads:[~2017-10-21 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 22:24 [PATCH v3 net] dccp/tcp: fix ireq->opt races Eric Dumazet
2017-10-20 6:04 ` David Miller
2017-10-20 6:18 ` David Miller
2017-10-20 15:58 ` Eric Dumazet
2017-10-20 16:04 ` [PATCH v4 net] tcp/dccp: " Eric Dumazet
2017-10-21 1:18 ` David Miller [this message]
2017-10-20 21:26 ` [PATCH v3 net] dccp/tcp: " kbuild test robot
2017-10-20 21:39 ` Eric Dumazet
2017-10-21 0:36 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021.021844.13388346477680130.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.