From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
marcelo.leitner@gmail.com, sd@queasysnail.net
Subject: Re: [PATCH net 0/2] net: diag: fix a potential security issue
Date: Sat, 21 Oct 2017 02:27:37 +0100 (WEST) [thread overview]
Message-ID: <20171021.022737.1906342496133825805.davem@davemloft.net> (raw)
In-Reply-To: <cover.1508398111.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Thu, 19 Oct 2017 15:32:23 +0800
> This patch is to void the potential security issue that the family
> or protocol modules are autoloaded when requesting _diag module by
> not requesting _diag module if the family or protocol is not added
> or registered in sock_diag and inet_diag.
>
> As the repost of the patch '[PATCH net] sock_diag: request _diag
> module only when the family or proto has been registered', this
> patchset fixes the compiling errors when INET is not set, and
> also split into two patches to make it clear to review.
This makes no sense to me.
Any user can just open a socket() in the appropriate protocol
family to cause the module to be loaded.
If someone wants modules to not be loaded, block them using
traditional module loading infrastructure mechanisms. Or
don't load the module at all.
Sorry I am not applying this.
next prev parent reply other threads:[~2017-10-21 1:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 7:32 [PATCH net 0/2] net: diag: fix a potential security issue Xin Long
2017-10-19 7:32 ` [PATCH net 1/2] sock_diag: request _diag module only when the family has been registered Xin Long
2017-10-19 7:32 ` [PATCH net 2/2] inet_diag: request _diag module only when the proto " Xin Long
2017-10-21 1:27 ` David Miller [this message]
[not found] ` <CADvbK_fWmmC3ggpoT--Pxk3GxZ8Gq_rbdFGTuXk-BuTHTO=eXw@mail.gmail.com>
2017-10-21 6:18 ` [PATCH net 0/2] net: diag: fix a potential security issue Eric Dumazet
2017-10-21 6:51 ` Xin Long
2017-10-21 7:45 ` Eric Dumazet
2017-10-21 8:45 ` Xin Long
2017-10-21 9:45 ` Xin Long
2017-10-21 11:16 ` David Miller
2017-10-21 11:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021.022737.1906342496133825805.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.