From: "Richard W.M. Jones" <rjones@redhat.com>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
RISC-V SW Dev <sw-dev@groups.riscv.org>
Subject: Re: [Qemu-devel] [sw-dev] [RFC] RISC-V Decoder generator
Date: Sat, 21 Oct 2017 07:44:45 +0100 [thread overview]
Message-ID: <20171021064444.GJ30459@redhat.com> (raw)
In-Reply-To: <6968797c-f64c-69ff-2fa6-79c4fb3440c9@mail.uni-paderborn.de>
On Fri, Oct 20, 2017 at 03:46:54PM +0200, Bastian Koppelmann wrote:
> I asked you for feedback some while ago regarding a modular RISC-V QEMU
> target (see discussion [1]). I tried getting it to work with the good
> old C preprocessor and quickly realized that it is too limiting. Instead
> I created a data-driven decoder generator written in python (see the
> code on github [2]) using YAML as a description language.
>
> I'd like to get some feedback whether this is acceptable to be
> upstreamed to QEMU or if you have any suggestions for improvements.
> Right now only RV32I instruction are implemented in this scheme.
My suggestion would be to reimplement (part of) the s390x decoder
using this scheme. That would give us a direct comparison of how your
scheme is better or worse than the existing macros.
Will you be at the KVM Forum next week?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2017-10-21 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 13:46 [Qemu-devel] [RFC] RISC-V Decoder generator Bastian Koppelmann
2017-10-20 16:57 ` Richard Henderson
2017-10-22 13:18 ` Bastian Koppelmann
2017-10-21 6:44 ` Richard W.M. Jones [this message]
2017-10-22 13:22 ` [Qemu-devel] [sw-dev] " Bastian Koppelmann
2017-10-24 21:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021064444.GJ30459@redhat.com \
--to=rjones@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=sw-dev@groups.riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.