From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753345AbdJUJEJ (ORCPT <rfc822;w@1wt.eu>);
        Sat, 21 Oct 2017 05:04:09 -0400
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46120 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753242AbdJUJEH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 21 Oct 2017 05:04:07 -0400
Date: Sat, 21 Oct 2017 10:03:48 +0100
From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Takashi <tiwai@suse.de>,
        Pierre <pierre-louis.bossart@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        Shreyas NC <shreyas.nc@intel.com>, patches.audio@intel.com,
        alan@linux.intel.com, Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, srinivas.kandagatla@linaro.org,
        plai@codeaurora.org, Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH 02/14] soundwire: Add SoundWire bus type
Message-ID: <20171021090348.3wjl6nwoiklgdbrp@sirena.org.uk>
References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com>
 <1508382211-3154-3-git-send-email-vinod.koul@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zr7fpkts36fgjypc"
Content-Disposition: inline
In-Reply-To: <1508382211-3154-3-git-send-email-vinod.koul@intel.com>
X-Cookie: MIT:
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--zr7fpkts36fgjypc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote:

> +	ret = dev_pm_domain_attach(dev, false);
> +	if (ret) {
> +		dev_err(dev, "Failed to attach PM domain: %d\n", ret);
> +		return ret;
> +	}
> +
> +	ret = drv->probe(slave, id);
> +	if (ret) {
> +		dev_err(dev, "Probe of %s failed: %d\n", drv->name, ret);
> +		return ret;
> +	}

We don't detach the power domain if the probe fails.

--zr7fpkts36fgjypc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlnrDXMACgkQJNaLcl1U
h9Ar0Af/T7qO4x2xlt8fTJYwi5j7edhrXFLn6k/GrWYw7zcjBkmek5fAICx0ZMfY
zgab49wQk15NIb+NmnghM5KR/wpvsME3FLkQLkEub8SNc6BEEEsQ3HJdRZHsODr+
sbfQeqACEokS4aYdhXZmQr0vBAjV6pSHcpt68QKvbgvOApFk37iNryYzZh1UdEKA
nNovkf5jA4GUha6XM7Q8I8gqpP3llQbprfMOnJ/LEvpsjGxecpDL70ppkfo3drlP
18KTvFhbiXDSqN40U/xROOFqrM3XRgJfyVNffbzRJNX+vCao6cJjqdvXYpsksZq+
fbQS/xsSdxCsjOKkJlsTbh/9oqo3jg==
=a72b
-----END PGP SIGNATURE-----

--zr7fpkts36fgjypc--