On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote: > + /* device is probed so let's read the properties now */ > + if (slave->ops && slave->ops->read_prop) > + slave->ops->read_prop(slave); Is it valid for us to not be able to read the properties? > + fwnode_property_read_u32(node, "mipi-sdw-port-max-wordlength", > + &dpn[i].max_word); > + fwnode_property_read_u32(node, "mipi-sdw-port-min-wordlength", > + &dpn[i].min_word); Don't we know this stuff simply by virtue of knowing what device we're talking to (given that there aren't class devices)?