From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbdJVCZJ (ORCPT ); Sat, 21 Oct 2017 22:25:09 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57804 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbdJVCZI (ORCPT ); Sat, 21 Oct 2017 22:25:08 -0400 Date: Sun, 22 Oct 2017 03:25:05 +0100 (WEST) Message-Id: <20171022.032505.1139984864002614492.davem@davemloft.net> To: bernd.edlinger@hotmail.de Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 21 Oct 2017 19:25:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bernd Edlinger Date: Sat, 21 Oct 2017 06:51:30 +0000 > This is the possible reason for different hard to reproduce > problems on my ARMv7-SMP test system. > > The symptoms are in recent kernels imprecise external aborts, > and in older kernels various kinds of network stalls and > unexpected page allocation failures. > > My testing indicates that the trouble started between v4.5 and v4.6 > and prevails up to v4.14. > > Using the dirty_tx before acquiring the spin lock is clearly > wrong and was first introduced with v4.6. > > Fixes: e3ad57c96715 ("stmmac: review RX/TX ring management") > > Signed-off-by: Bernd Edlinger Applied, thank you.