From: Jeff King <peff@peff.net>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
"Robert P . J . Day" <rpjday@crashcourse.ca>
Subject: Re: [PATCH v3 0/3] deprecate git stash save
Date: Sun, 22 Oct 2017 20:39:22 -0400 [thread overview]
Message-ID: <20171023003922.h3hr3y5ap2tk7byu@sigill.intra.peff.net> (raw)
In-Reply-To: <20171022170409.8565-1-t.gummerer@gmail.com>
On Sun, Oct 22, 2017 at 06:04:06PM +0100, Thomas Gummerer wrote:
> Thanks Peff for the review of the previous rounds.
>
> In addition to addressing the review comments, this round adds another
> patch getting rid of the extra help with an unknown option to git
> stash push.
Yeah, the reasoning in the commit message of patch 3 makes sense to me.
> Thomas Gummerer (3):
> replace git stash save with git stash push in the documentation
> mark git stash push deprecated in the man page
> stash: remove now superfluos help for "stash push"
The whole thing looks good. Thanks!
-Peff
next prev parent reply other threads:[~2017-10-23 0:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 20:00 [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path) Thomas Gummerer
2017-10-05 20:10 ` [PATCH 2/1] mention git stash push first in the man page Thomas Gummerer
2017-10-17 4:14 ` Jeff King
2017-10-17 21:45 ` Thomas Gummerer
2017-10-17 21:47 ` Jeff King
2017-10-19 18:08 ` Thomas Gummerer
2017-10-20 8:04 ` Robert P. J. Day
2017-10-21 6:20 ` Jeff King
2017-10-21 6:43 ` Robert P. J. Day
2017-10-12 0:56 ` [RFC] deprecate git stash save? Junio C Hamano
2017-10-12 11:14 ` Junio C Hamano
2017-10-16 18:19 ` Thomas Gummerer
2017-10-17 4:13 ` [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path) Jeff King
2017-10-17 21:47 ` Thomas Gummerer
2017-10-19 18:33 ` [PATCH v2 1/2] replace git stash save with git stash push in the documentation Thomas Gummerer
2017-10-19 18:33 ` [PATCH v2 2/2] mark git stash push deprecated in the man page Thomas Gummerer
2017-10-21 6:28 ` Jeff King
2017-10-22 16:31 ` Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 0/3] deprecate git stash save Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 1/3] replace git stash save with git stash push in the documentation Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 2/3] mark git stash push deprecated in the man page Thomas Gummerer
2017-10-22 17:04 ` [PATCH v3 3/3] stash: remove now superfluos help for "stash push" Thomas Gummerer
2017-10-23 0:39 ` Jeff King [this message]
2017-10-23 1:19 ` [PATCH v3 0/3] deprecate git stash save Junio C Hamano
2017-10-23 5:18 ` Jeff King
2017-10-23 6:26 ` Junio C Hamano
2017-10-23 5:47 ` Robert P. J. Day
2017-10-23 1:32 ` Junio C Hamano
2017-10-21 6:26 ` [PATCH v2 1/2] replace git stash save with git stash push in the documentation Jeff King
2017-10-22 16:28 ` Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023003922.h3hr3y5ap2tk7byu@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=rpjday@crashcourse.ca \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.