All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 3/9] ui: use correct union field for key number
Date: Mon, 23 Oct 2017 11:19:41 +0200	[thread overview]
Message-ID: <20171023091947.20771-4-kraxel@redhat.com> (raw)
In-Reply-To: <20171023091947.20771-1-kraxel@redhat.com>

From: "Daniel P. Berrange" <berrange@redhat.com>

The code converting key numbers to QKeyCode in the 'input-send-event'
command mistakenly accessed the key->u.qcode union field instead of
the key->u.number field. This is harmless because the fields use the
same size datatype in both cases, but none the less it should be fixed
to avoid confusion.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20171019142848.572-4-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/input.c b/ui/input.c
index 290b47354a..4e821f8f2b 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -162,7 +162,7 @@ void qmp_input_send_event(bool has_device, const char *device,
         if (evt->type == INPUT_EVENT_KIND_KEY &&
             evt->u.key.data->key->type == KEY_VALUE_KIND_NUMBER) {
             KeyValue *key = evt->u.key.data->key;
-            QKeyCode code = qemu_input_key_number_to_qcode(key->u.qcode.data);
+            QKeyCode code = qemu_input_key_number_to_qcode(key->u.number.data);
             qemu_input_event_send_key_qcode(con, code, evt->u.key.data->down);
         } else {
             qemu_input_event_send(con, evt);
-- 
2.9.3

  parent reply	other threads:[~2017-10-23  9:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23  9:19 [Qemu-devel] [PULL 0/9] Input 20171023 patches Gerd Hoffmann
2017-10-23  9:19 ` [Qemu-devel] [PULL 1/9] input: use hex in ps2 keycode trace events Gerd Hoffmann
2017-10-23  9:19 ` [Qemu-devel] [PULL 2/9] ui: fix crash with sendkey and raw key numbers Gerd Hoffmann
2017-10-23  9:19 ` Gerd Hoffmann [this message]
2017-10-23  9:19 ` [Qemu-devel] [PULL 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq) Gerd Hoffmann
2017-10-27  7:29   ` Daniel P. Berrange
2017-11-01  7:58     ` Gerd Hoffmann
2017-11-01 10:00       ` Daniel P. Berrange
2017-10-23  9:19 ` [Qemu-devel] [PULL 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination Gerd Hoffmann
2017-10-23  9:19 ` [Qemu-devel] [PULL 6/9] ps2: fix scancodess sent for Pause key in AT set 1 Gerd Hoffmann
2017-10-23  9:19 ` [Qemu-devel] [PULL 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination Gerd Hoffmann
2017-10-23  9:19 ` [Qemu-devel] [PULL 8/9] ui: normalize the 'sysrq' key into the 'print' key Gerd Hoffmann
2017-10-23  9:19 ` [Qemu-devel] [PULL 9/9] ui: pull in latest keycodemapdb Gerd Hoffmann
2017-10-25 14:23 ` [Qemu-devel] [PULL 0/9] Input 20171023 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023091947.20771-4-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.