From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbdJWJbH (ORCPT ); Mon, 23 Oct 2017 05:31:07 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37313 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbdJWJbG (ORCPT ); Mon, 23 Oct 2017 05:31:06 -0400 Date: Mon, 23 Oct 2017 11:31:04 +0200 From: Pavel Machek To: Lee Jones Cc: Andrey Smirnov , Johan Hovold , linux-kernel , Chris Healy , Lucas Stach , Nikita Yushchenko , Greg Kroah-Hartman Subject: Re: [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory Processor Message-ID: <20171023093104.GH32228@amd> References: <20171013061321.31252-1-andrew.smirnov@gmail.com> <20171013061321.31252-2-andrew.smirnov@gmail.com> <20171013072731.GC29243@localhost> <20171013161700.2anaqwthq4rnco6f@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bygAmIonOAIqBxQB" Content-Disposition: inline In-Reply-To: <20171013161700.2anaqwthq4rnco6f@dell> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bygAmIonOAIqBxQB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > >> drivers/platform/Kconfig | 2 + > > >> drivers/platform/Makefile | 1 + > > >> drivers/platform/rave/Kconfig | 26 ++ > > >> drivers/platform/rave/Makefile | 1 + > > >> drivers/platform/rave/rave-sp.c | 677 +++++++++++++++++++++++++++++= +++++++++++ > > > > > > First of all, why do these live in drivers/platform and why don't use > > > the mfd subsystem to implement this driver (instead of rolling your o= wn > > > mfd-implementation)? > > > > >=20 > > Because when I submitted this driver to MFD Lee Jones told me that it > > didn't belong to that subsystem and should be added to the kernel in > > "drivers/platform". >=20 > When I first reviewed this driver, it looked far too complex to be an > MFD driver. Most of the code doesn't deal with what I'd expect to be > handled in MFD. Why do you have ~600 lines of protocol handling? Some drivers are more complex than other ones... I don't think that's unexpected. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --bygAmIonOAIqBxQB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlntttgACgkQMOfwapXb+vJ9MgCffAqO7MQa8q+f4/sBM1ConuUK docAoJ9tlnr5DbJFqkTXoaxbQcgPlTv0 =YX5k -----END PGP SIGNATURE----- --bygAmIonOAIqBxQB--