From: Guenter Roeck <linux@roeck-us.net>
To: Romain Porte <romain.porte@nokia.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [1/2] pmbus: added tps544c20 driver with trimming support
Date: Mon, 23 Oct 2017 15:17:02 -0700 [thread overview]
Message-ID: <20171023221702.GD6066@roeck-us.net> (raw)
In-Reply-To: <47c2dd13-c357-56fa-6886-08ce6e2b9d92@nokia.com>
On Mon, Oct 23, 2017 at 03:34:24PM +0200, Romain Porte wrote:
> On 21/10/2017 18:20, Guenter Roeck wrote:
> >This should be part of device programming in manufacturing, just like,
> >say, current calibration. It should not be user programmable, even less so
> >runtime programmable. On top of that, we definitely don't want to make
> >STORE_USER_ALL available to user space. Both can too easily result in
> >a bricked device (bad enough that the register values are writable using
> >i2cset).
> After some work, I have tested accessing these registers using i2cget and
> i2cset and I can reproduce all the features I have implemented in this
> driver. I think am going to re-implement my calibration procedure using
> i2cget and i2cset in userspace.
>
> I thought it could be a good idea to make this accessible by sysfs entries.
> Since one must read the datasheet for calibrating the component, I guess it
> is not a big deal to have users to find register addresses/sizes and write
> to them using userspace commands instead of (over?)simplifying it by
> providing dedicated sysfs entries.
>
Anyone tasked with calibration type work on any chip should _really_ read
the datasheet.
Guenter
next prev parent reply other threads:[~2017-10-23 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 10:39 [PATCH 0/2] pmbus: Add MFR-specific commands for TPS544C20 Romain Porte
2017-10-20 10:39 ` [PATCH 1/2] pmbus: added tps544c20 driver with trimming support Romain Porte
2017-10-21 16:20 ` [1/2] " Guenter Roeck
2017-10-23 7:54 ` Romain Porte
2017-10-23 22:15 ` Guenter Roeck
2017-10-23 13:34 ` Romain Porte
2017-10-23 22:17 ` Guenter Roeck [this message]
2017-10-20 10:39 ` [PATCH 2/2] pmbus: removed tps544c20 from generic pmbus driver Romain Porte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023221702.GD6066@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.porte@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.