From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 66B3A1C0621 for ; Wed, 25 Oct 2017 09:47:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5F5DD89AB9 for ; Wed, 25 Oct 2017 09:47:06 +0000 (UTC) Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gl5JlsPX-rtU for ; Wed, 25 Oct 2017 09:47:05 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2F44C88BD9 for ; Wed, 25 Oct 2017 09:47:05 +0000 (UTC) Date: Wed, 25 Oct 2017 20:46:59 +1100 From: "Tobin C. Harding" Subject: Re: [PATCH] staging: ccree: Fix lines longer than 80 characters Message-ID: <20171025094659.GG15832@eros> References: <20171023145318.8748-1-stephen@brennan.io> <20171024030245.GC1429@eros> <20171024094431.GG1429@eros> <20171025065258.GA31377@pride.cult> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171025065258.GA31377@pride.cult> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Stephen Brennan Cc: driverdev-devel@linuxdriverproject.org, Greg Kroah-Hartman On Tue, Oct 24, 2017 at 11:52:58PM -0700, Stephen Brennan wrote: > Hi Gilad & Tobin, > > > > Perhaps, if Stephen is willing, re-write the code to be more readable > > > by, for example, using a temp > > > variable for the register address, and in doing so both making the > > > code more readable as well as > > > treating the symptom? > > I'm definitely willing; however, I don't know the hardware, so I'm already > off to a bad start with questions like "which integer type is appropriate > for the register address?" > > > Oh, refactoring, that's a whole 'nother story. I'm a huge fan. And I agree with you that that is the > > correct way to deal with 'line over 80' warnings. For me, it helped to get a few _trivial_ > > checkpatch fixes in before I moved onto refactoring. 'line over 80' warnings are great to fix if > > viewed as an opportunity to refactor but not so great if viewed as a trivial white space fix to get > > started with. > > I think this makes the most sense right now. A pure trivial change is what > I'd like, to help get some experience with the development process and > working with the community. I'll look for something else (hopefully within > the same staging driver, since you've all been super welcoming) and submit > a patch for it. Hopefully I'll circle back for some slightly less trivial > refactors after that! When you want to link a few patches together into a series I wrote a blog post a while back, check it out if you want some further guidance http://tobin.cc/blog/kernel-dev-2/ Stick at it. There ain't nothin' to it but to do it Good luck, Tobin _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel