From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751863AbdJYNXc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 09:23:32 -0400
Received: from mail.kernel.org ([198.145.29.99]:42938 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750952AbdJYNXb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 09:23:31 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B61421871
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org
Date: Wed, 25 Oct 2017 08:23:28 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: kishon@ti.com, bhelgaas@google.com, linux-omap@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug
Message-ID: <20171025132328.GK21840@bhelgaas-glaptop.roam.corp.google.com>
References: <1508417009-30869-1-git-send-email-faiz_abbas@ti.com>
 <20171024195950.GD21840@bhelgaas-glaptop.roam.corp.google.com>
 <c99814db-e349-e4b1-c652-561a3ca1abec@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c99814db-e349-e4b1-c652-561a3ca1abec@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 25, 2017 at 01:51:53PM +0530, Faiz Abbas wrote:
> Bjorn,
> 
> On Wednesday 25 October 2017 01:29 AM, Bjorn Helgaas wrote:
> > On Thu, Oct 19, 2017 at 06:13:29PM +0530, Faiz Abbas wrote:
> >> Enable support for printing the LTSSM link state for debugging PCI
> >> when link is down.
> >>
> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> > 
> > Applied with Kishon's ack to pci/host-dra7xx for v4.15, thanks!
> > 
> > I tweaked the "link up" testing as follows (what I suggested before):
> > 
> > 
> > @@ -118,8 +157,18 @@ static int dra7xx_pcie_link_up(struct dw_pcie *pci)
> >  {
> >  	struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
> >  	u32 reg = dra7xx_pcie_readl(dra7xx, PCIECTRL_DRA7XX_CONF_PHY_CS);
> > +	int link_up = !!(reg & LINK_UP);
> > +	u32 cmd_reg;
> > +	u32 ltssm_state;
> > +
> > +	if (!link_up) {
> > +		cmd_reg = dra7xx_pcie_readl(dra7xx,
> > +					    PCIECTRL_DRA7XX_CONF_DEVICE_CMD);
> > +		ltssm_state = (cmd_reg & GENMASK(7, 2)) >> 2;
> > +		dev_dbg(pci->dev, "Link state: %s\n", state[ltssm_state]);
> > +	}
> >  
> > -	return !!(reg & LINK_UP);
> > +	return link_up;
> >  }
> >  
> >  static void dra7xx_pcie_stop_link(struct dw_pcie *pci)
> > 
> 
> I wanted to send another version with David's suggestions included.
> Please don't merge.

Dropped.