All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Winiarski" <michal.winiarski@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 08/12] drm/i915: Add information needed to track engine preempt state
Date: Wed, 25 Oct 2017 22:00:16 +0200	[thread overview]
Message-ID: <20171025200020.16636-9-michal.winiarski@intel.com> (raw)
In-Reply-To: <20171025200020.16636-1-michal.winiarski@intel.com>

We shouldn't inspect ELSP context status (or any other bits depending on
specific submission backend) when using GuC submission.
Let's use another piece of HWSP for preempt context, to write its bit of
information, meaning that preemption has finished, and hardware is now
idle.

Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mcgee@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Oscar Mateo <oscar.mateo@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Jeff McGee <jeff.mcgee@intel.com>
---
 drivers/gpu/drm/i915/intel_ringbuffer.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
index c15161e56964..4a5a08985328 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
@@ -626,6 +626,8 @@ intel_write_status_page(struct intel_engine_cs *engine, int reg, u32 value)
  */
 #define I915_GEM_HWS_INDEX		0x30
 #define I915_GEM_HWS_INDEX_ADDR (I915_GEM_HWS_INDEX << MI_STORE_DWORD_INDEX_SHIFT)
+#define I915_GEM_HWS_PREEMPT_INDEX	0x32
+#define I915_GEM_HWS_PREEMPT_ADDR (I915_GEM_HWS_PREEMPT_INDEX << MI_STORE_DWORD_INDEX_SHIFT)
 #define I915_GEM_HWS_SCRATCH_INDEX	0x40
 #define I915_GEM_HWS_SCRATCH_ADDR (I915_GEM_HWS_SCRATCH_INDEX << MI_STORE_DWORD_INDEX_SHIFT)
 
@@ -778,6 +780,11 @@ static inline u32 intel_hws_seqno_address(struct intel_engine_cs *engine)
 	return engine->status_page.ggtt_offset + I915_GEM_HWS_INDEX_ADDR;
 }
 
+static inline u32 intel_hws_preempt_done_address(struct intel_engine_cs *engine)
+{
+	return engine->status_page.ggtt_offset + I915_GEM_HWS_PREEMPT_ADDR;
+}
+
 /* intel_breadcrumbs.c -- user interrupt bottom-half for waiters */
 int intel_engine_init_breadcrumbs(struct intel_engine_cs *engine);
 
-- 
2.13.6

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-10-25 20:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 20:00 [PATCH 00/12] Preemption with GuC, fourth try Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 01/12] drm/i915/guc: Do not use 0 for GuC doorbell cookie Michał Winiarski
2017-10-25 20:00 ` [PATCH 02/12] drm/i915/guc: Extract GuC stage desc pool creation into a helper Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 03/12] drm/i915/guc: Allocate separate shared data object for GuC communication Michał Winiarski
2017-10-25 21:04   ` Michel Thierry
2017-10-25 20:00 ` [PATCH v2 04/12] drm/i915/guc: Add preemption action to GuC firmware interface Michał Winiarski
2017-10-25 20:00 ` [PATCH v3 05/12] drm/i915/guc: Add a second client, to be used for preemption Michał Winiarski
2017-10-26 12:50   ` Michal Wajdeczko
2017-10-26 13:20   ` [PATCH v4] " Michał Winiarski
2017-10-26 13:32     ` [PATCH v5] " Michał Winiarski
2017-10-26 13:44       ` Michal Wajdeczko
2017-10-26 14:17       ` [PATCH v6] " Michał Winiarski
2017-10-26 18:49         ` Michel Thierry
2017-10-26 20:02           ` Chris Wilson
2017-10-26 20:15             ` Michel Thierry
2017-10-25 20:00 ` [PATCH 06/12] drm/i915/guc: Split guc_wq_item_append Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 07/12] drm/i915: Extract "emit write" part of emit breadcrumb functions Michał Winiarski
2017-10-25 20:00 ` Michał Winiarski [this message]
2017-10-25 20:00 ` [PATCH v2 09/12] drm/i915/guc: Keep request->priority for its lifetime Michał Winiarski
2017-10-25 20:00 ` [PATCH v3 10/12] drm/i915: Rename helpers used for unwinding, use macro for can_preempt Michał Winiarski
2017-10-25 20:15   ` Chris Wilson
2017-10-25 20:00 ` [PATCH v4 11/12] drm/i915/guc: Preemption! With GuC Michał Winiarski
2017-10-25 20:24   ` Chris Wilson
2017-10-25 21:14   ` Chris Wilson
2017-10-26  7:27   ` [PATCH v5] " Michał Winiarski
2017-10-26 13:35     ` [PATCH v6] " Michał Winiarski
2017-10-25 20:00 ` [PATCH 12/12] HAX Enable GuC Submission for CI Michał Winiarski
2017-10-25 21:06 ` ✗ Fi.CI.BAT: failure for Preemption with GuC, fourth try Patchwork
2017-10-26  7:48 ` ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev2) Patchwork
2017-10-26 13:41 ` ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev3) Patchwork
2017-10-26 13:59 ` ✓ Fi.CI.BAT: success for Preemption with GuC, fourth try (rev5) Patchwork
2017-10-26 14:43 ` ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev6) Patchwork
2017-10-26 15:18 ` ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev5) Patchwork
2017-10-26 15:59 ` ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev6) Patchwork
2017-10-26 20:37 ` [PATCH 00/12] Preemption with GuC, fourth try Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2017-10-09 14:52 [PATCH 00/12] Preemption with GuC, second try Michał Winiarski
2017-10-09 14:52 ` [PATCH 08/12] drm/i915: Add information needed to track engine preempt state Michał Winiarski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171025200020.16636-9-michal.winiarski@intel.com \
    --to=michal.winiarski@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.