From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932210AbdJYVHw (ORCPT ); Wed, 25 Oct 2017 17:07:52 -0400 Received: from mail-ve1eur01on0119.outbound.protection.outlook.com ([104.47.1.119]:24761 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751792AbdJYVHu (ORCPT ); Wed, 25 Oct 2017 17:07:50 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=avagin@virtuozzo.com; Date: Wed, 25 Oct 2017 14:07:38 -0700 From: Andrei Vagin To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , torvalds@linux-foundation.org, peterz@infradead.org, hpa@zytor.com, tglx@linutronix.de, Andy Lutomirski Subject: Re: [PATCH 1/3] x86/entry: Fix idtentry unwind hint Message-ID: <20171025210737.GA16091@outlook.office365.com> References: <931d57f0551ed7979d5e7e05370d445c8e5137f8.1508516398.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <931d57f0551ed7979d5e7e05370d445c8e5137f8.1508516398.git.jpoimboe@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [4.16.175.162] X-ClientProxiedBy: AM5PR0701CA0011.eurprd07.prod.outlook.com (2603:10a6:203:51::21) To HE1PR08MB0746.eurprd08.prod.outlook.com (2a01:111:e400:59b1::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4757f607-dd5c-4a2a-5439-08d51bec7107 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:HE1PR08MB0746; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;3:ggc4JPsPQ1A3EShjQALF9UB/edbc6DxXeJL2oc4VHyPuP1JIjFaOA6AjId3RIPuQKdwpgbcHnbnKDpPUXnwfz/U6x4GmkklV71a61pF8Z96byNMpvz8xLENHpVuXJrowJCk07kRNfGNlwDOivVBjDzsSLLtaa3zz2WTk0fmJdFVlBUjhCMahk0+8JZUwwg8bme09orFT0nxnqZD44prZ3egM9xibltpjVswxupvuntqUIDTxBr5XGV6Nba0thI5g;25:N1hqiCx71cABU7qOj05q7aZTR0Fg8HQUq+FyQGEIAaqGmIMhY2nd7tltE7V07yulaRbYQ7/ARuPS0oOsIfgR3vAwPVeSTTep/AdcHB0oMWeUafg1pqfOfKRZTORkPcQheXfik0tnqxf0Jlw524B0XQL7zMY400KkIT01wrhaAnW0SdOrs+s5eLtTP14mx1NbONgzV20Z5tlDqJr6CIpafCF4NDGHDmBEWsVeqDuCAbRWP9C/dWAf8acuKjm9q+ftCx/yURsW7gx36WirmqFK2sEYZkvRJrhZFy4/pgWRJVdalg/dfghycp9sMkVzwp6eVM7bLHw1QIMI+XCT6LHvVw==;31:cJBsHIEkk4Lu4M6g6C3rxy41MF57fxYPUOr1B3SJwBvi/Cl0VY79KqvxVilRm9pVyk5A359N8XC/UFzLYKkm268Zjc0J1vatOrmcMRz1Ioz/KIUSUCuVGxD5YDBsSY/UqXbxMFq1DyPE9q5/g9QmpyT8wTfHyhlSSIftn+4OjdMlhmGQvJ2UnsZ5Vtr7NDyaE0FUfKMHGd0HezyZIkhNEcTAlKyYSbKBUX/I72Qhv/o= X-MS-TrafficTypeDiagnostic: HE1PR08MB0746: X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;20:pDH7iJDKO2V02NXtieYrGp1H2yOUxdENQ267VPEuXwXTivS9t/AvOY+f2y1I55mEKRs55Zfmlp1WM2aJtdPzcnrz85S6kW30WRo4aXCx+95+3PEyVHeMgNvlOkBMqKehFf1cbmbgkY54aqtR1E1AuuOrmupKRi1BV0yI2Ey6/0LmC6BY8i1wWo73kJ/U/Pyp+JzsyDKCbPi2au3HyozMYFlcu6xkOdTscp35IgSEU7oN4zAmmkrJs66UFSRkG9kqSlabkwsbBAWAXBPi8ZjNNxP6FWIxmZN7OZHkAq8i0GwnjrrT3McLQlxMSUgkcwBKvyHG6IS1CjxPg3DeERS0gYqRSJ8159VfGE7xL7Lr7IHhXM5qyCA1hNwMxQi9HD1AsBG4G+yS6N8ICNr0CdI5WmYsuSZzHajd/wtrngJOoGQ=;4:TaTE22Xog8Zs9fmQFOFNHsmsah/YEPRNQJ4WCxdpCoHNG6/hHZrsCMOy9kFqJRmRUHByBbJUle+ZjsgioODx8b+Ups17YU6oifNDti2xvWx5YMmzNLVkl441OeIdGkaPJdnespdI4eFo8GZKDp0ccJUIkYKvgawJkAJXI6OTsKEr6KYyWtJqXpPA4cO9+4MLgsO6yAOW8vQlhxsiFMPheUJ0s0Z236zBQ3zvYh8aE5bnDjO4v8YLNdD+Qhm44AMm X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR08MB0746;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR08MB0746; X-Forefront-PRVS: 0471B73328 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(199003)(24454002)(189002)(81156014)(81166006)(8936002)(101416001)(478600001)(316002)(106356001)(25786009)(7736002)(105586002)(54906003)(9686003)(55016002)(16586007)(58126008)(53936002)(4326008)(53416004)(189998001)(8676002)(37156001)(6246003)(33656002)(305945005)(69596002)(23686003)(229853002)(6506006)(3846002)(68736007)(50466002)(6916009)(16526018)(6666003)(2950100002)(6116002)(5660300001)(97736004)(83506002)(1076002)(47776003)(66066001)(86362001)(2906002)(50986999)(575784001)(54356999)(76176999)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR08MB0746;H:outlook.office365.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;HE1PR08MB0746;23:OScT6oba1wxwkb2O+Bf4zSo34OP2TSWqQnFZoLdgrue?= =?koi8-r?Q?aYpz9SRbvQRlpTWj9YfqGf71Ll8WOkPsANSz+8RI9/RxaEJfaNvNt+EA/y5cS7?= =?koi8-r?Q?r5kyCdvdHA9rt199CVykWr6Lx9+ul58Xqyf6ycq7focIH3mQ7weeflE8oh5U5S?= =?koi8-r?Q?7ikbLYaFk7qiJTrvpJkfNfFhUytdBHArcTfL5oVyswv/Blwv5bBXKnPzlikGCO?= =?koi8-r?Q?cq07zD8nuHdnf+k0GF09rehFN/wE5tpVWoInFX8Oh45hxRoaIQJvYWlI9HheU/?= =?koi8-r?Q?JZCHzGI5hllw0wn1mXn6ePWlF6vKJLGhlvNqpJvbChGiqoTz9sGwnL/m2QY10L?= =?koi8-r?Q?hyzhXN29z1STYSUBLTSwGSmUwk4a+QoZNiCGsE4UlZ6GTTLM8kFK0OwUEh2dND?= =?koi8-r?Q?QW/vdccqzqw2Wh1q4wknfsOEDqHga8KVJgD96ZRbtUya8eApQRvth5N4ya8yQF?= =?koi8-r?Q?3c3wE1XW5azkde+PvxzadxI1D2pVBlM5+9paV7nd4qFMOB9FHSISiOZscEUCrN?= =?koi8-r?Q?czSa/bZTCF72k48NJKD5l1oV8SmcaiEyQRNZ940VgRdgJnNXDtfCA98F1WSNOz?= =?koi8-r?Q?mhB69jKv6cmX53n7VJY/PsBb3HoHGcxbB9sLmMnhbTWe+pKSfW2RUlM9pAIvmC?= =?koi8-r?Q?njbHkAvNUVUFWbV2r6tRYtnhgusMRRKO6thD3FFWK/v5acSSlnx2SgG9+EHCbK?= =?koi8-r?Q?MC2Y/lvKggoEu49lVqxB0wryrk9SS49OWEStR5oyyhchd4ho9QaM2zl94tWr+z?= =?koi8-r?Q?BUO5b0Lr6K/K1xRIgafp2qUShHNGat2NHoxdSV4Pcitb+Cm4HFNl3Kj3S0Vh36?= =?koi8-r?Q?JKPhXKQmPcNxIuwts46u3XOpEzgM9jAe9WeMGE+C+2IuguMcozYRtsYJjgn3Dl?= =?koi8-r?Q?KW11vwIq3X0mv2Ur4kft091llOi+RzYl5GbAydWtwut1bJrsLX8360MNy+KvWE?= =?koi8-r?Q?5PdmMRuEFVAE/EVmpEN4AGcMvYHPwtPnp3D31MI5yU/yxHg2UuMR+UalgdQwaH?= =?koi8-r?Q?ijEPaqskG3vuFzxtgOht9KSQFNgHyYBAbTbaoYrJBQ/bcmdaVSgInJRQiZajd9?= =?koi8-r?Q?opkMxs/G5rpVEmS9ohk/RI4YZVJi3Z3gPzIrLjN9yNi8+ngyIfWi4dnx0qRBT5?= =?koi8-r?Q?G3BTCKWHtCFQxlwVJ84wWbsrJhZTxQHRZ220w77kRjHyyy4rsDNQgNyic1KF27?= =?koi8-r?Q?GzhtrmRjepq9FZ9PPdWBa1aSUBrNyNZr3DcQRWpMMAPxaWwEMPPfusZPCL1?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;6:jVNOfEcS6m/JfDA5M/ATzJUSW1xBvYgz6/jIZkHHU+qpTBhkxrL3NtJxkLlJ6fn1E7QaG8hAKo8Me+sLiDl9b4w3wiAb+zacfITcyT2IIrdf9QKBng77LKzeJwZ448AnrodRTXUJ6IqGdab3cDFRPLoNtaqONEZGEBUlG+LUWyqFU/3JXGzQsx38WLnzTAWBwrR2DD4K9csHgOYHIzbjTDG8BFVBlGoYSSNcBed3EoMW8Nf+MybmN0xcGMEAiwjWKQeoWvUHxKq9+QVGqoTO3g4o00vVmNbIg0BaqdReglvcu+wgbOnbWLXPQu56MHaYnrxz49Zaq9cGf0OeOT9F5w==;5:BH5aP6DEuBS7z6eeW5chd4UnUDh3NhARUfKuYttRhPvdceL+e9Uswc7U6NrAQT8bVUtcdL+tZEOfBjQIB/gbMdhhEkdsPFKe2f34Je+DQqUqiBgtDV/w19Ev7CezvGrUjAgzUmU2w9C3lF2fTTohVg==;24:l001zKMtJBCLPqM7RN+nUr9vTN2LOvW0fW6vBWy+1zXkJWUrPndvhXgBOtWmqTMEBnmaOmwPHYRmgjbvbCER+EfzTkCq/gbpKsZrvL3raXI=;7:yIjsVJbeSgGbxdnB/RznsgywpqZJqkaBERs+LYGflJ9xBIQXKOR7nb7OlRBWpkGAgTmf1qYEl3/t+MtMmPXnMOV6MUTxq98ln7MkQQ5uAlsdODY59BwhNuBnN93h1HG+5Ory9xe66u+pjH/ni/lmdnfXh1+ByXlm2k5Eq2wA3nd1zBW0zxhlp+7Umwr9HJTqo8ZnRY5zTqdHgzrQ+oj5xqD32SFT8n9l6A1BsY15Dhc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0746;20:yued1xQl4aAWm1ETwEhdkvTEmzFUJpksDsfX/p31IZddu8woGMSlHCU4TOKLny7w0G1JR86x6Vgxzh3bwzuxes8g8Sucb0ytbUZNHFWUlCEdpxWc9fA24ZKArgUxFYBf/eAIxNaj/YzQCLgDNXJErTBi1S9AEuln7j80NFkFx/Y= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 21:07:44.3767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4757f607-dd5c-4a2a-5439-08d51bec7107 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0746 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Josh, Here is one more warning: [ 5.852094] WARNING: can't dereference iret registers at ffffb6ce01b7ffe0 for ip entry_SYSCALL_64_fastpath+0xa/0xc2 [avagin@laptop linux]$ git describe tip/auto-latest v4.14-rc6-471-g376214a8543d On Fri, Oct 20, 2017 at 11:21:33AM -0500, Josh Poimboeuf wrote: > This fixes the following ORC warning in the 'int3' entry code: > > WARNING: can't dereference iret registers at ffff8801c5f17fe0 for ip ffffffff95f0d94b > > The ORC metadata had the wrong stack offset for the iret registers. > > Their location on the stack is dependent on whether the exception has an > error code. > > Reported-and-tested-by: Andrei Vagin > Fixes: 8c1f75587a18 ("x86/entry/64: Add unwind hint annotations") > Signed-off-by: Josh Poimboeuf > --- > arch/x86/entry/entry_64.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S > index 49167258d587..f6cdb7a1455e 100644 > --- a/arch/x86/entry/entry_64.S > +++ b/arch/x86/entry/entry_64.S > @@ -808,7 +808,7 @@ apicinterrupt IRQ_WORK_VECTOR irq_work_interrupt smp_irq_work_interrupt > > .macro idtentry sym do_sym has_error_code:req paranoid=0 shift_ist=-1 > ENTRY(\sym) > - UNWIND_HINT_IRET_REGS offset=8 > + UNWIND_HINT_IRET_REGS offset=\has_error_code*8 > > /* Sanity check */ > .if \shift_ist != -1 && \paranoid == 0 > -- > 2.13.6 >