From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932504AbdJZOIl (ORCPT ); Thu, 26 Oct 2017 10:08:41 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40153 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932465AbdJZOIa (ORCPT ); Thu, 26 Oct 2017 10:08:30 -0400 Date: Thu, 26 Oct 2017 17:07:43 +0300 From: Dan Carpenter To: Alexandre Belloni Cc: SF Markus Elfring , linux-iio@vger.kernel.org, Andreas Dannenberg , Felipe Balbi , Hartmut Knaack , Javier Martinez Canillas , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] iio/light/opt3001: Use common error handling code in opt3001_get_lux() Message-ID: <20171026140743.wfstmoy3lbolm7xv@mwanda> References: <20171026134852.bprrrv3htfyryyy4@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171026134852.bprrrv3htfyryyy4@piout.net> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 26, 2017 at 03:48:52PM +0200, Alexandre Belloni wrote: > On 26/10/2017 at 14:17:30 +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 26 Oct 2017 14:06:49 +0200 > > > > * Add jump targets so that two error messages are stored only once > > at the end of this function implementation. > > > > * Adjust condition checks. > > > > * Replace string literals by references to two global constant variables > > in eight functions. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/iio/light/opt3001.c | 88 +++++++++++++++++++-------------------------- > > 1 file changed, 36 insertions(+), 52 deletions(-) > > > > diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c > > index 54d88b60e303..23d7d4e6ae61 100644 > > --- a/drivers/iio/light/opt3001.c > > +++ b/drivers/iio/light/opt3001.c > > @@ -77,6 +77,9 @@ > > #define OPT3001_RESULT_READY_SHORT 150 > > #define OPT3001_RESULT_READY_LONG 1000 > > > > +static char const read_failure[] = "failed to read register %02x\n"; > > +static char const write_failure[] = "failed to write register %02x\n"; > > + > > If you are going to do that The answer to that question is we're not going to do that... Please stop taking bad ideas and making them even more complicated and worse. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 26 Oct 2017 14:07:43 +0000 Subject: Re: [PATCH] iio/light/opt3001: Use common error handling code in opt3001_get_lux() Message-Id: <20171026140743.wfstmoy3lbolm7xv@mwanda> List-Id: References: <20171026134852.bprrrv3htfyryyy4@piout.net> In-Reply-To: <20171026134852.bprrrv3htfyryyy4@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexandre Belloni Cc: SF Markus Elfring , linux-iio@vger.kernel.org, Andreas Dannenberg , Felipe Balbi , Hartmut Knaack , Javier Martinez Canillas , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , LKML , kernel-janitors@vger.kernel.org On Thu, Oct 26, 2017 at 03:48:52PM +0200, Alexandre Belloni wrote: > On 26/10/2017 at 14:17:30 +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 26 Oct 2017 14:06:49 +0200 > > > > * Add jump targets so that two error messages are stored only once > > at the end of this function implementation. > > > > * Adjust condition checks. > > > > * Replace string literals by references to two global constant variables > > in eight functions. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > drivers/iio/light/opt3001.c | 88 +++++++++++++++++++-------------------------- > > 1 file changed, 36 insertions(+), 52 deletions(-) > > > > diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c > > index 54d88b60e303..23d7d4e6ae61 100644 > > --- a/drivers/iio/light/opt3001.c > > +++ b/drivers/iio/light/opt3001.c > > @@ -77,6 +77,9 @@ > > #define OPT3001_RESULT_READY_SHORT 150 > > #define OPT3001_RESULT_READY_LONG 1000 > > > > +static char const read_failure[] = "failed to read register %02x\n"; > > +static char const write_failure[] = "failed to write register %02x\n"; > > + > > If you are going to do that The answer to that question is we're not going to do that... Please stop taking bad ideas and making them even more complicated and worse. regards, dan carpenter