From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] drm/i915: Give more details for the active-when-parking warning for the engines
Date: Fri, 27 Oct 2017 12:06:17 +0100 [thread overview]
Message-ID: <20171027110617.31745-4-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20171027110617.31745-1-chris@chris-wilson.co.uk>
If the we think the engine is still active when we attempt to park it,
we want more details -- so dump the engine state.
References: https://bugs.freedesktop.org/show_bug.cgi?id=103479
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 9767586e2289..6895a90af008 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -1613,14 +1613,20 @@ void intel_engines_park(struct drm_i915_private *i915)
struct intel_engine_cs *engine;
enum intel_engine_id id;
- /*
- * We are committed now to parking the engines, make sure there
- * will be no more interrupts arriving later.
- */
- if (!intel_engines_are_idle(dev_priv))
- DRM_ERROR("Timeout waiting for engines to idle\n");
-
for_each_engine(engine, i915, id) {
+ /*
+ * We are committed now to parking the engines, make sure there
+ * will be no more interrupts arriving later and the engines
+ * are truly idle.
+ */
+ if (!intel_engine_is_idle(engine)) {
+ struct drm_printer p = drm_debug_printer(__func__);
+
+ DRM_ERROR("%s is not idle before parking\n",
+ engine->name);
+ intel_engine_dump(engine, &p);
+ }
+
if (engine->park)
engine->park(engine);
--
2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-27 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 11:06 [PATCH 1/4] drm: Enable pr_debug() for drm_printer Chris Wilson
2017-10-27 11:06 ` [PATCH 2/4] drm/i915: Enable pr_debug() for CI debugging Chris Wilson
2017-10-27 11:06 ` [PATCH 3/4] drm/i915: Move parking-while-active warning to intel_engines_park() Chris Wilson
2017-10-27 13:12 ` Mika Kuoppala
2017-10-27 11:06 ` Chris Wilson [this message]
2017-10-27 13:25 ` [PATCH 4/4] drm/i915: Give more details for the active-when-parking warning for the engines Mika Kuoppala
2017-10-27 13:33 ` Chris Wilson
2017-11-01 15:12 ` Chris Wilson
2017-10-27 12:44 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm: Enable pr_debug() for drm_printer Patchwork
2017-10-27 15:47 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-01 17:20 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-11-01 17:45 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027110617.31745-4-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.