From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 30 Oct 2017 08:52:33 +1100 From: Dave Chinner Subject: Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support Message-ID: <20171029215233.GF3666@dastard> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <20171020074750.GA13568@lst.de> <20171020093148.GA20304@lst.de> <20171026105850.GA31161@quack2.suse.cz> <1509061831.25213.2.camel@intel.com> <20171027064854.GE3666@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Dan Williams Cc: "mhocko@suse.com" , "jack@suse.cz" , "benh@kernel.crashing.org" , "dave.hansen@linux.intel.com" , "heiko.carstens@de.ibm.com" , "bfields@fieldses.org" , "linux-mm@kvack.org" , "paulus@samba.org" , "Hefty, Sean" , "jlayton@poochiereds.net" , "mawilcox@microsoft.com" , "linux-rdma@vger.kernel.org" , "mpe@ellerman.id.au" , "dledford@redhat.com" , "hch@lst.de" , "jgunthorpe@obsidianresearch.com" , "hal.rosenstock@gmail.com" , "schwidefsky@de.ibm.com" , "viro@zeniv.linux.org.uk" , "gerald.schaefer@de.ibm.com" , "linux-nvdimm@lists.01.org" , "darrick.wong@oracle.com" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" List-ID: On Fri, Oct 27, 2017 at 01:42:16PM +0200, Dan Williams wrote: > [replying from my phone, please forgive formatting] > > On Friday, October 27, 2017, Dave Chinner wrote: > > > > > Here are the two primary patches in > > > the series, do you think the extent-busy approach would be cleaner? > > > > The XFS_DAXDMA.... > > > > $DEITY that patch is so ugly I can't even bring myself to type it. > > > Right, and so is the problem it's trying to solve. So where do you want to > go from here? > > I could go back to the FL_ALLOCATED approach, but use page idle callbacks > instead of polling for the lease end notification. Or do we want to try > busy extents? My concern with busy extents is that it requires more per-fs > code. I don't care if it takes more per-fs code to solve the problem - dumping butt-ugly, nasty locking crap into filesystems that filesystem developers are completely unable to test is about the worst possible solution you can come up with. Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support Date: Mon, 30 Oct 2017 08:52:33 +1100 Message-ID: <20171029215233.GF3666@dastard> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <20171020074750.GA13568@lst.de> <20171020093148.GA20304@lst.de> <20171026105850.GA31161@quack2.suse.cz> <1509061831.25213.2.camel@intel.com> <20171027064854.GE3666@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Dan Williams Cc: "mhocko@suse.com" , "jack@suse.cz" , "benh@kernel.crashing.org" , "dave.hansen@linux.intel.com" , "heiko.carstens@de.ibm.com" , "bfields@fieldses.org" , "linux-mm@kvack.org" , "paulus@samba.org" , "Hefty, Sean" , "jlayton@poochiereds.net" , "mawilcox@microsoft.com" , "linux-rdma@vger.kernel.org" , "mpe@ellerman.id.au" , "dledford@redhat.com" , "hch@lst.de" , "jgunthorpe@obsidianresearch.com" , "hal.rosenstock@gmail.com" , "schwidefsky@de.ibm.com" , viro@zeniv.linux. List-Id: linux-rdma@vger.kernel.org On Fri, Oct 27, 2017 at 01:42:16PM +0200, Dan Williams wrote: > [replying from my phone, please forgive formatting] > > On Friday, October 27, 2017, Dave Chinner wrote: > > > > > Here are the two primary patches in > > > the series, do you think the extent-busy approach would be cleaner? > > > > The XFS_DAXDMA.... > > > > $DEITY that patch is so ugly I can't even bring myself to type it. > > > Right, and so is the problem it's trying to solve. So where do you want to > go from here? > > I could go back to the FL_ALLOCATED approach, but use page idle callbacks > instead of polling for the lease end notification. Or do we want to try > busy extents? My concern with busy extents is that it requires more per-fs > code. I don't care if it takes more per-fs code to solve the problem - dumping butt-ugly, nasty locking crap into filesystems that filesystem developers are completely unable to test is about the worst possible solution you can come up with. Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdJ2Vw4 (ORCPT ); Sun, 29 Oct 2017 17:52:56 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:3822 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbdJ2Vwy (ORCPT ); Sun, 29 Oct 2017 17:52:54 -0400 Date: Mon, 30 Oct 2017 08:52:33 +1100 From: Dave Chinner To: Dan Williams Cc: "mhocko@suse.com" , "jack@suse.cz" , "benh@kernel.crashing.org" , "dave.hansen@linux.intel.com" , "heiko.carstens@de.ibm.com" , "bfields@fieldses.org" , "linux-mm@kvack.org" , "paulus@samba.org" , "Hefty, Sean" , "jlayton@poochiereds.net" , "mawilcox@microsoft.com" , "linux-rdma@vger.kernel.org" , "mpe@ellerman.id.au" , "dledford@redhat.com" , "hch@lst.de" , "jgunthorpe@obsidianresearch.com" , "hal.rosenstock@gmail.com" , "schwidefsky@de.ibm.com" , "viro@zeniv.linux.org.uk" , "gerald.schaefer@de.ibm.com" , "linux-nvdimm@lists.01.org" , "darrick.wong@oracle.com" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" Subject: Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support Message-ID: <20171029215233.GF3666@dastard> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <20171020074750.GA13568@lst.de> <20171020093148.GA20304@lst.de> <20171026105850.GA31161@quack2.suse.cz> <1509061831.25213.2.camel@intel.com> <20171027064854.GE3666@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2017 at 01:42:16PM +0200, Dan Williams wrote: > [replying from my phone, please forgive formatting] > > On Friday, October 27, 2017, Dave Chinner wrote: > > > > > Here are the two primary patches in > > > the series, do you think the extent-busy approach would be cleaner? > > > > The XFS_DAXDMA.... > > > > $DEITY that patch is so ugly I can't even bring myself to type it. > > > Right, and so is the problem it's trying to solve. So where do you want to > go from here? > > I could go back to the FL_ALLOCATED approach, but use page idle callbacks > instead of polling for the lease end notification. Or do we want to try > busy extents? My concern with busy extents is that it requires more per-fs > code. I don't care if it takes more per-fs code to solve the problem - dumping butt-ugly, nasty locking crap into filesystems that filesystem developers are completely unable to test is about the worst possible solution you can come up with. Cheers, Dave. -- Dave Chinner david@fromorbit.com