From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbdJ3OGK (ORCPT ); Mon, 30 Oct 2017 10:06:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:54104 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbdJ3OGJ (ORCPT ); Mon, 30 Oct 2017 10:06:09 -0400 Date: Mon, 30 Oct 2017 15:06:04 +0100 From: Borislav Petkov To: Tyler Baicar Cc: Fengguang Wu , Huang Ying , Chen Gong , Linus Torvalds , Linux Kernel Mailing List , Will Deacon , "Rafael J. Wysocki" Subject: Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150 Message-ID: <20171030140553.akse6wcfzmuhldad@pd.tnic> References: <20171029225155.qcum5i75awrt5tzm@wfg-t540p.sh.intel.com> <20171029231835.3725fnd5yehlmqob@wfg-t540p.sh.intel.com> <20171030110511.scfrdtlnf5lbdhu5@pd.tnic> <2d40fa2f-0b88-a466-fc67-26653f5f72e8@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2d40fa2f-0b88-a466-fc67-26653f5f72e8@codeaurora.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 10:01:52AM -0400, Tyler Baicar wrote: > This is not as important for polling sources as it is for the > interrupt sources since polling sources are regularly checked and > shouldn't be used for fatal error scenarios. For interrupt driven > sources, there could already be a fatal error pending, so we should > handle it immediately. Whatever it is, you can't call it there as it could deadlock. You need to think about doing that differently. If you can't come up with a solution quickly, it should be reverted and then you can try again later. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --