All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Oleksandr Grytsov <al1img@gmail.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com,
	ian.jackson@eu.citrix.com,
	Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Subject: Re: [PATCH 3/5] xl: add PV sound condif parser
Date: Mon, 30 Oct 2017 17:58:22 +0000	[thread overview]
Message-ID: <20171030175822.52n6uqjouogmb25z@citrix.com> (raw)
In-Reply-To: <1506937764-30329-4-git-send-email-al1img@gmail.com>

On Mon, Oct 02, 2017 at 12:49:22PM +0300, Oleksandr Grytsov wrote:
> +static void parse_vsnd_card_config(const XLU_Config *config,
> +                                   XLU_ConfigValue *card_value,
> +                                   libxl_domain_config *d_config)
> +{
> +    int ret;
> +
> +    XLU_ConfigList *card_list;
> +
> +    // get card

Please delete this.

> +    ret = xlu_cfg_value_get_list(config, card_value,  &card_list, 0);
> +
> +    if (ret) {
> +        fprintf(stderr, "Failed to get vsnd card list: %s\n", strerror(ret));
> +        goto out;
> +    }
> +
> +    libxl_device_vsnd *vsnd;
> +
> +    vsnd = ARRAY_EXTEND_INIT(d_config->vsnds,
> +                             d_config->num_vsnds,
> +                             libxl_device_vsnd_init);
> +
> +    const char *card_item;
> +    int item = 0;
> +

Mixing code and declarations will break.

> +    while ((card_item = xlu_cfg_get_listitem(card_list, item++)) != NULL) {
> +        ret = parse_vsnd_item(vsnd, card_item);
> +        if (ret) goto out;
> +    }
> +
> +    ret = 0;
> +
> +out:
> +    if (ret) exit(EXIT_FAILURE);
> +}

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-10-30 17:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02  9:49 [PATCH 0/5] libxl: add PV sound device Oleksandr Grytsov
2017-10-02  9:49 ` [PATCH 1/5] " Oleksandr Grytsov
2017-10-30 17:39   ` Wei Liu
2017-10-31 14:51     ` Oleksandr Grytsov
2017-10-31 14:54       ` Wei Liu
2017-10-31 15:00     ` Oleksandr Grytsov
2017-10-02  9:49 ` [PATCH 2/5] libxl: add vsnd list and info Oleksandr Grytsov
2017-10-30 17:51   ` Wei Liu
2017-10-02  9:49 ` [PATCH 3/5] xl: add PV sound condif parser Oleksandr Grytsov
2017-10-30 17:58   ` Wei Liu [this message]
2017-10-02  9:49 ` [PATCH 4/5] xl: add vsnd CLI commands Oleksandr Grytsov
2017-10-30 17:59   ` Wei Liu
2017-10-02  9:49 ` [PATCH 5/5] docs: add PV sound device config Oleksandr Grytsov
2017-10-30 18:00   ` Marek Marczykowski-Górecki
2017-10-31 15:54     ` Oleksandr Grytsov
2017-10-24  7:27 ` [PATCH 0/5] libxl: add PV sound device Oleksandr Grytsov
2017-10-30 12:36   ` Oleksandr Grytsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171030175822.52n6uqjouogmb25z@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=al1img@gmail.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=oleksandr_grytsov@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.