From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbdJaEUI (ORCPT ); Tue, 31 Oct 2017 00:20:08 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:43941 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbdJaEUG (ORCPT ); Tue, 31 Oct 2017 00:20:06 -0400 X-Google-Smtp-Source: ABhQp+TuQofesXscsJRtdePtGaSZs/QflVVtnUOstwZu9wAX1qwf8XnFKvpwqAj8yJUrmW/Ap5qJgg== Date: Tue, 31 Oct 2017 05:20:02 +0100 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Jonathan Woithe Cc: Andy Shevchenko , Darren Hart , Andy Shevchenko , Harvey , Platform Driver , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection Message-ID: <20171031042002.GA9788@larwa.localdomain> References: <20171025042946.13225-1-kernel@kempniu.pl> <20171029212806.GA8470@kmp-mobile.hq.kempniu.pl> <20171030121257.GA28737@marvin.atrad.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171030121257.GA28737@marvin.atrad.com.au> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Do you consider this an important fix? We are at -rc7 now, I'm not > > sure it's so critical. Tell me if you consider otherwise. > > I agree - from my perspective I wouldn't have thought it so critical as to > push it out this late in the development cycle. It's not a regression as > such and is largely cosmetic. Others may argue differently though. I agree as well. The erroneous log messages will only be generated when any rfkill device in the system is enabled or disabled, so IMHO this is mostly a nuisance thus can be handled when convenient. -- Best regards, Michał Kępień