From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753149AbdJaHk0 (ORCPT ); Tue, 31 Oct 2017 03:40:26 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:52888 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752174AbdJaHkY (ORCPT ); Tue, 31 Oct 2017 03:40:24 -0400 Date: Tue, 31 Oct 2017 09:40:21 +0200 From: Sakari Ailus To: Wenyou Yang Cc: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, Nicolas Ferre , devicetree@vger.kernel.org, Jonathan Corbet , Hans Verkuil , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List Subject: Re: [PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver Message-ID: <20171031074020.udssku6pazxooa7q@valkosipuli.retiisi.org.uk> References: <20171031011146.6899-1-wenyou.yang@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031011146.6899-1-wenyou.yang@microchip.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wenyou, On Tue, Oct 31, 2017 at 09:11:42AM +0800, Wenyou Yang wrote: > Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 > VGA camera image sensor. For the next version, could you rearrange your patches a bit as follows: 1. DT bindings 2. The driver and MAINTAINERS entry Putting the MAINTAINERS entry separately from the driver emits a warning from checkpatch.pl. Bindings are naturally separate from driver and should precede the driver as the driver musn't use undocumented bindings. Thanks. -- Sakari Ailus e-mail: sakari.ailus@iki.fi From mboxrd@z Thu Jan 1 00:00:00 1970 From: sakari.ailus@iki.fi (Sakari Ailus) Date: Tue, 31 Oct 2017 09:40:21 +0200 Subject: [PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver In-Reply-To: <20171031011146.6899-1-wenyou.yang@microchip.com> References: <20171031011146.6899-1-wenyou.yang@microchip.com> Message-ID: <20171031074020.udssku6pazxooa7q@valkosipuli.retiisi.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Wenyou, On Tue, Oct 31, 2017 at 09:11:42AM +0800, Wenyou Yang wrote: > Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 > VGA camera image sensor. For the next version, could you rearrange your patches a bit as follows: 1. DT bindings 2. The driver and MAINTAINERS entry Putting the MAINTAINERS entry separately from the driver emits a warning from checkpatch.pl. Bindings are naturally separate from driver and should precede the driver as the driver musn't use undocumented bindings. Thanks. -- Sakari Ailus e-mail: sakari.ailus at iki.fi