All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: dovgaluk@ispras.ru
Subject: [Qemu-devel] [RFCPATCH11/20] target/arm/arm-powertctl: drop BQL assertions
Date: Tue, 31 Oct 2017 13:48:40 +0300	[thread overview]
Message-ID: <20171031104840.3079.81200.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20171031104741.3079.26584.stgit@pasha-VirtualBox>

From: Alex Bennée <alex.bennee@linaro.org>

The powerctl code is run in the context of the vCPU changing power
state. It does not need the BQL to protect its changes.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 target/arm/arm-powerctl.c |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c
index 25207cb..9661a59 100644
--- a/target/arm/arm-powerctl.c
+++ b/target/arm/arm-powerctl.c
@@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state,
     g_free(info);
 
     /* Finally set the power status */
-    assert(qemu_mutex_iothread_locked());
     target_cpu->power_state = PSCI_ON;
 }
 
@@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id,
     ARMCPU *target_cpu;
     struct CpuOnInfo *info;
 
-    assert(qemu_mutex_iothread_locked());
-
     DPRINTF("cpu %" PRId64 " (EL %d, %s) @ 0x%" PRIx64 " with R0 = 0x%" PRIx64
             "\n", cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry,
             context_id);
@@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state,
 {
     ARMCPU *target_cpu = ARM_CPU(target_cpu_state);
 
-    assert(qemu_mutex_iothread_locked());
     target_cpu->power_state = PSCI_OFF;
     target_cpu_state->halted = 1;
     target_cpu_state->exception_index = EXCP_HLT;
@@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid)
     CPUState *target_cpu_state;
     ARMCPU *target_cpu;
 
-    assert(qemu_mutex_iothread_locked());
-
     DPRINTF("cpu %" PRId64 "\n", cpuid);
 
     /* change to the cpu we are powering up */
@@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid)
     CPUState *target_cpu_state;
     ARMCPU *target_cpu;
 
-    assert(qemu_mutex_iothread_locked());
-
     DPRINTF("cpu %" PRId64 "\n", cpuid);
 
     /* change to the cpu we are resetting */

  parent reply	other threads:[~2017-10-31 10:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 10:47 [Qemu-devel] [RFCPATCH00/20] replay additions Pavel Dovgalyuk
2017-10-31 10:47 ` [Qemu-devel] [RFCPATCH01/20] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-10-31 10:47 ` [Qemu-devel] [RFCPATCH02/20] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-10-31 10:47 ` [Qemu-devel] [RFCPATCH03/20] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH04/20] replay: fix processing async events Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH05/20] replay: fixed replay_enable_events Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2017-10-31 11:21   ` no-reply
2017-10-31 12:13   ` no-reply
2017-10-31 13:26   ` no-reply
2017-10-31 16:41   ` no-reply
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH07/20] replay: added replay log format description Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH08/20] replay: make safe vmstop at record/replay Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH09/20] replay: save prior value of the host clock Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH10/20] icount: fixed saving/restoring of icount warp timers Pavel Dovgalyuk
2017-10-31 12:47   ` no-reply
2017-10-31 10:48 ` Pavel Dovgalyuk [this message]
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH12/20] cpus: push BQL lock to qemu_*_wait_io_event Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH13/20] cpus: only take BQL for sleeping threads Pavel Dovgalyuk
2017-10-31 10:48 ` [Qemu-devel] [RFCPATCH14/20] replay/replay.c: bump REPLAY_VERSION again Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH15/20] replay/replay-internal.c: track holding of replay_lock Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH16/20] replay: make locking visible outside replay code Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH17/20] replay: push replay_mutex_lock up the call tree Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH18/20] cpu-exec: don't overwrite exception_index Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH19/20] cpu-exec: reset exit flag before calling cpu_exec_nocache Pavel Dovgalyuk
2017-10-31 10:49 ` [Qemu-devel] [RFCPATCH20/20] replay: don't destroy mutex at exit Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031104840.3079.81200.stgit@pasha-VirtualBox \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.