From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v4] bus/pci: fix vfio mode
Date: Tue, 31 Oct 2017 15:11:38 +0100
Message-ID: <20171031141138.GJ10890@bidouze.vm.6wind.com>
References: <8492fe4cf1a8d6f15d389c9148e4942f1d060a40.1509381300.git.gaetan.rivet@6wind.com>
 <20171030223227.8852-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 392E81B232
 for <dev@dpdk.org>; Tue, 31 Oct 2017 15:11:53 +0100 (CET)
Received: by mail-wm0-f65.google.com with SMTP id t139so23542028wmt.1
 for <dev@dpdk.org>; Tue, 31 Oct 2017 07:11:53 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20171030223227.8852-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote:
> Revert back to using VFIO_PRESENT as a marker to enable compilation
> of VFIO-related segments.
> 
> VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and
> kernel version support check.
> 
> eal_vfio.h VFIO_PRESENT related check ordered to be compatible with
> rte_vfio.h one, no functional modification.
> 
> Fixes: 279b581c897d ("vfio: expose functions")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v4:
> 
> * Alternative to v3, not superseding it, need to decide which one to
> get. This one:
>   * fixes vfio for new kernels
>   * fixes build for old kernels for vfio enabled in config case
>   * print warning if vfio enabled in config but not supported by kernel
> 

Thanks for the v4.

Well, as I stated before, I am more of the opinion of letting the
VFIO_PRESENT define only within eal_vfio.h.

But in the end, as long as everything is working, I'm fine with it.
Unless someone is explicitly interested in going with my version, let's
keep yours. If needed I can always submit a new v4 that would actually
work with old kernels.

Sorry about the mess concerning VFIO. I found late in the work that I
needed to touch it, and did not have the test-bed for it.