From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754660AbdKAMYZ (ORCPT ); Wed, 1 Nov 2017 08:24:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:53060 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbdKAMYX (ORCPT ); Wed, 1 Nov 2017 08:24:23 -0400 Date: Wed, 01 Nov 2017 21:24:16 +0900 (KST) Message-Id: <20171101.212416.1255930983444370494.davem@davemloft.net> To: colin.king@canonical.com Cc: johan@kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hso: remove redundant unused variable dev From: David Miller In-Reply-To: <20171031120147.22348-1-colin.king@canonical.com> References: <20171031120147.22348-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Nov 2017 05:24:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 31 Oct 2017 12:01:47 +0000 > From: Colin Ian King > > The pointer dev is being assigned but is never used, hence it is > redundant and can be removed. Cleans up clang warning: > > drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is > never read > > Signed-off-by: Colin Ian King Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 01 Nov 2017 12:24:16 +0000 Subject: Re: [PATCH] net: hso: remove redundant unused variable dev Message-Id: <20171101.212416.1255930983444370494.davem@davemloft.net> List-Id: References: <20171031120147.22348-1-colin.king@canonical.com> In-Reply-To: <20171031120147.22348-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: colin.king@canonical.com Cc: johan@kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin King Date: Tue, 31 Oct 2017 12:01:47 +0000 > From: Colin Ian King > > The pointer dev is being assigned but is never used, hence it is > redundant and can be removed. Cleans up clang warning: > > drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is > never read > > Signed-off-by: Colin Ian King Applied.