From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933153AbdKAMQP (ORCPT ); Wed, 1 Nov 2017 08:16:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36412 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932128AbdKAMQN (ORCPT ); Wed, 1 Nov 2017 08:16:13 -0400 Date: Wed, 1 Nov 2017 13:16:11 +0100 From: Andrew Lunn To: "Maciej S. Szmigiero" Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel Subject: Re: [PATCH v2] net: phy: leds: Add support for "link" trigger Message-ID: <20171101121611.GD12680@lunn.ch> References: <52ce25a6-8d6b-039d-ca08-90595eb9ee72@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52ce25a6-8d6b-039d-ca08-90595eb9ee72@maciej.szmigiero.name> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -123,6 +153,10 @@ int phy_led_triggers_register(struct phy_device *phy) > while (i--) > phy_led_trigger_unregister(&phy->phy_led_triggers[i]); > devm_kfree(&phy->mdio.dev, phy->phy_led_triggers); > +out_unreg_link: > + phy_led_trigger_unregister(phy->led_link_trigger); > +out_free_link: > + devm_kfree(&phy->mdio.dev, phy->led_link_trigger); Hi Maciej The point of the devm_ API is that you don't need to worry about freeing the memory. The core will do it, when the driver is removed. I guess you are just copying the code above, which i would also say is unnecessary. Andrew