From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933047AbdKAMbG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 08:31:06 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:36445 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932858AbdKAMbE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 08:31:04 -0400
Date: Wed, 1 Nov 2017 13:31:02 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: phy: leds: Add support for "link" trigger
Message-ID: <20171101123102.GF12680@lunn.ch>
References: <52ce25a6-8d6b-039d-ca08-90595eb9ee72@maciej.szmigiero.name>
 <20171101121611.GD12680@lunn.ch>
 <b789b023-2e7b-1f5b-59a6-9676db74e850@maciej.szmigiero.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b789b023-2e7b-1f5b-59a6-9676db74e850@maciej.szmigiero.name>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Yes, I did it the same way as the existing code did for phy->phy_led_triggers
> for reasons of both consistency and also to be on the safe side because
> maybe there is some non-obvious reason why it has to be freed
> explicitly (?).
 
Hi Maciej

Occasionally, there is a need to call devm_kfree(). But i don't see
anything here why it is needed. So i would drop your devm_kfree(), and
if you feel like it, add an additional patch removing the existing
one.

Thanks
	Andrew