From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: Fix static use of function graph
Date: Wed, 1 Nov 2017 12:43:10 -0400 [thread overview]
Message-ID: <20171101124310.3ab66a69@gandalf.local.home> (raw)
In-Reply-To: <1509546824-46165-2-git-send-email-julien.thierry@arm.com>
On Wed, 1 Nov 2017 14:33:43 +0000
Julien Thierry <julien.thierry@arm.com> wrote:
> Function graph does not work currently when CONFIG_DYNAMIC_TRACE is not
> set. This is because ftrace_function_trace is not always set to ftrace_stub
> when function_graph is in use.
>
> Do not skip checking of graph tracer functions when ftrace_function_trace
> is set.
>
> Signed-off-by: Julien Thierry <julien.thierry@arm.com>
My arm code is very rusty and I have no idea if this works or not, but
for what it's worth.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> arch/arm64/kernel/entry-ftrace.S | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S
> index e1be42e..1175f58 100644
> --- a/arch/arm64/kernel/entry-ftrace.S
> +++ b/arch/arm64/kernel/entry-ftrace.S
> @@ -108,13 +108,8 @@ ENTRY(_mcount)
> mcount_get_lr x1 // function's lr (= parent's pc)
> blr x2 // (*ftrace_trace_function)(pc, lr);
>
> -#ifndef CONFIG_FUNCTION_GRAPH_TRACER
> -skip_ftrace_call: // return;
> - mcount_exit // }
> -#else
> - mcount_exit // return;
> - // }
> -skip_ftrace_call:
> +skip_ftrace_call: // }
> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> ldr_l x2, ftrace_graph_return
> cmp x0, x2 // if ((ftrace_graph_return
> b.ne ftrace_graph_caller // != ftrace_stub)
> @@ -123,9 +118,8 @@ skip_ftrace_call:
> adr_l x0, ftrace_graph_entry_stub // != ftrace_graph_entry_stub))
> cmp x0, x2
> b.ne ftrace_graph_caller // ftrace_graph_caller();
> -
> - mcount_exit
> #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
> + mcount_exit
> ENDPROC(_mcount)
>
> #else /* CONFIG_DYNAMIC_FTRACE */
> --
> 1.9.1
next prev parent reply other threads:[~2017-11-01 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 14:33 [PATCH 0/2] Ftrace fixes Julien Thierry
2017-11-01 14:33 ` [PATCH 1/2] arm64: Fix static use of function graph Julien Thierry
2017-11-01 16:43 ` Steven Rostedt [this message]
2017-11-02 4:43 ` AKASHI Takahiro
2017-11-02 10:18 ` Russell King - ARM Linux
2017-11-03 9:25 ` Julien Thierry
2017-11-06 1:36 ` AKASHI Takahiro
2017-11-01 14:33 ` [PATCH 2/2] perf: Fix ftrace builtin when kernel doesn't have function_graph Julien Thierry
2017-11-01 14:33 ` Julien Thierry
2017-11-01 16:44 ` Steven Rostedt
2017-11-01 16:44 ` Steven Rostedt
2017-11-01 16:58 ` Julien Thierry
2017-11-01 16:58 ` Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101124310.3ab66a69@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.