From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v5 01/30] regset: Add support for dynamically sized regsets Date: Wed, 1 Nov 2017 13:16:44 +0000 Message-ID: <20171101131644.GL19485@e103592.cambridge.arm.com> References: <1509465082-30427-1-git-send-email-Dave.Martin@arm.com> <1509465082-30427-2-git-send-email-Dave.Martin@arm.com> <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Content-Disposition: inline In-Reply-To: <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> To: Catalin Marinas Cc: linux-arch@vger.kernel.org, "H. J. Lu" , Okamoto Takayuki , libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , Dmitry Safonov , Will Deacon , Oleg Nesterov , Ingo Molnar , Alexander Viro , "H. Peter Anvin" , Thomas Gleixner , Alex =?iso-8859-1?Q?Benn=E9e?= , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Wed, Nov 01, 2017 at 11:42:29AM +0000, Catalin Marinas wrote: > On Tue, Oct 31, 2017 at 03:50:53PM +0000, Dave P Martin wrote: > > Currently the regset API doesn't allow for the possibility that > > regsets (or at least, the amount of meaningful data in a regset) > > may change in size. > > > > In particular, this results in useless padding being added to > > coredumps if a regset's current size is smaller than its > > theoretical maximum size. > > > > This patch adds a get_size() function to struct user_regset. > > Individual regset implementations can implement this function to > > return the current size of the regset data. A regset_size() > > function is added to provide callers with an abstract interface for > > determining the size of a regset without needing to know whether > > the regset is dynamically sized or not. > > > > The only affected user of this interface is the ELF coredump code: > > This patch ports ELF coredump to dump regsets with their actual > > size in the coredump. This has no effect except for new regsets > > that are dynamically sized and provide a get_size() implementation. > > > > Signed-off-by: Dave Martin > > Reviewed-by: Alex Bennée > > Reviewed-by: Catalin Marinas > > Cc: Oleg Nesterov > > Cc: Alexander Viro > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: Dmitry Safonov > > Cc: H. J. Lu > > > > --- > > > > **Dropped** Reviewed-by: Alex Bennée > > **Dropped** Reviewed-by: Catalin Marinas > > (due to bug fix applied against v4 of this patch.) > > It seems that the Reviewed-by tags are still there ;). Anyway, on the Oops, looks like that only happened on this patch. I've removed Alex's R-b from my own version in case of repost -- can you also do the same? > new patch: > > Reviewed-by: Catalin Marinas Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave.Martin@arm.com (Dave Martin) Date: Wed, 1 Nov 2017 13:16:44 +0000 Subject: [PATCH v5 01/30] regset: Add support for dynamically sized regsets In-Reply-To: <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> References: <1509465082-30427-1-git-send-email-Dave.Martin@arm.com> <1509465082-30427-2-git-send-email-Dave.Martin@arm.com> <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> Message-ID: <20171101131644.GL19485@e103592.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 01, 2017 at 11:42:29AM +0000, Catalin Marinas wrote: > On Tue, Oct 31, 2017 at 03:50:53PM +0000, Dave P Martin wrote: > > Currently the regset API doesn't allow for the possibility that > > regsets (or at least, the amount of meaningful data in a regset) > > may change in size. > > > > In particular, this results in useless padding being added to > > coredumps if a regset's current size is smaller than its > > theoretical maximum size. > > > > This patch adds a get_size() function to struct user_regset. > > Individual regset implementations can implement this function to > > return the current size of the regset data. A regset_size() > > function is added to provide callers with an abstract interface for > > determining the size of a regset without needing to know whether > > the regset is dynamically sized or not. > > > > The only affected user of this interface is the ELF coredump code: > > This patch ports ELF coredump to dump regsets with their actual > > size in the coredump. This has no effect except for new regsets > > that are dynamically sized and provide a get_size() implementation. > > > > Signed-off-by: Dave Martin > > Reviewed-by: Alex Benn?e > > Reviewed-by: Catalin Marinas > > Cc: Oleg Nesterov > > Cc: Alexander Viro > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: Dmitry Safonov > > Cc: H. J. Lu > > > > --- > > > > **Dropped** Reviewed-by: Alex Benn?e > > **Dropped** Reviewed-by: Catalin Marinas > > (due to bug fix applied against v4 of this patch.) > > It seems that the Reviewed-by tags are still there ;). Anyway, on the Oops, looks like that only happened on this patch. I've removed Alex's R-b from my own version in case of repost -- can you also do the same? > new patch: > > Reviewed-by: Catalin Marinas Cheers ---Dave