From: Wei Liu <wei.liu2@citrix.com>
To: Zhongze Liu <blackskygg@gmail.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 5/7] libxl: support unmapping static shared memory areas during domain destruction
Date: Wed, 1 Nov 2017 15:55:13 +0000 [thread overview]
Message-ID: <20171101155513.aaybskfhgxx2e32d@citrix.com> (raw)
In-Reply-To: <20171019023635.19812-6-blackskygg@gmail.com>
On Thu, Oct 19, 2017 at 10:36:33AM +0800, Zhongze Liu wrote:
> Add libxl__sshm_del to unmap static shared memory areas mapped by
> libxl__sshm_add during domain creation. The unmapping process is:
>
> * For a master: decrease the refcount of the sshm region, if the refcount
> reaches 0, cleanup the whole sshm path.
> * For a slave: unmap the shared pages, and cleanup related xs entries.
> decrease the refcount of the sshm region, if the refcount reaches 0,
> cleanup the whole sshm path.
>
This appears to be in line with what we discussed.
I would like to see some explanation for: if one or more of the things
the code does fail half way, the system is still going to be in a
consistent state. Most notably, there isn't going to be any page leaked
with uncleaned refs.
> +
> + rc = libxl__xs_transaction_commit(gc, &xt);
> + if (!rc) break;
> + if (rc < 0) goto out;
> + isretry = true;
Indentation.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-01 15:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 2:36 [PATCH v3 0/7] Allow setting up shared memory areas between VMs from xl config files Zhongze Liu
2017-10-19 2:36 ` [PATCH v3 1/7] libxc: add xc_domain_remove_from_physmap to wrap XENMEM_remove_from_physmap Zhongze Liu
2017-10-31 12:40 ` Wei Liu
2017-10-19 2:36 ` [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin Zhongze Liu
2017-10-19 11:58 ` Jan Beulich
2017-10-19 17:36 ` Daniel De Graaf
2017-10-20 6:14 ` Jan Beulich
2017-10-20 13:34 ` Daniel De Graaf
2017-10-22 11:21 ` Zhongze Liu
2017-10-23 7:26 ` Jan Beulich
2017-10-23 9:54 ` Zhongze Liu
2017-10-25 9:37 ` Zhongze Liu
2017-10-25 15:36 ` Zhongze Liu
2017-10-26 6:41 ` Jan Beulich
2017-10-19 17:36 ` Daniel De Graaf
2017-10-20 0:34 ` Zhongze Liu
2017-10-20 0:55 ` Zhongze Liu
2017-10-20 13:02 ` Daniel De Graaf
2017-10-19 2:36 ` [PATCH v3 3/7] libxl: introduce a new structure to represent static shared memory regions Zhongze Liu
2017-10-31 12:48 ` Wei Liu
2017-10-19 2:36 ` [PATCH v3 4/7] libxl: support mapping static shared memory areas during domain creation Zhongze Liu
2017-11-01 15:55 ` Wei Liu
2017-11-09 0:48 ` Zhongze Liu
2017-10-19 2:36 ` [PATCH v3 5/7] libxl: support unmapping static shared memory areas during domain destruction Zhongze Liu
2017-11-01 15:55 ` Wei Liu [this message]
2017-11-09 2:06 ` Zhongze Liu
2017-11-09 2:10 ` Zhongze Liu
2017-10-19 2:36 ` [PATCH v3 6/7] libxl:xl: add parsing code to parse "libxl_static_sshm" from xl config files Zhongze Liu
2017-10-19 2:36 ` [PATCH v3 7/7] docs: documentation about static shared memory regions Zhongze Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101155513.aaybskfhgxx2e32d@citrix.com \
--to=wei.liu2@citrix.com \
--cc=blackskygg@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.