From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754829AbdKAQyf (ORCPT ); Wed, 1 Nov 2017 12:54:35 -0400 Received: from mail-co1nam03on0055.outbound.protection.outlook.com ([104.47.40.55]:62816 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751681AbdKAQyd (ORCPT ); Wed, 1 Nov 2017 12:54:33 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; From: Tom Lendacky Subject: [PATCH] x86/mm: Remove unneeded TLB flush for in-place encryption To: x86@kernel.org Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Dave Hansen , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Thomas Gleixner Date: Wed, 01 Nov 2017 11:54:26 -0500 Message-ID: <20171101165426.1388.24866.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR18CA0052.namprd18.prod.outlook.com (10.173.57.142) To BN6PR12MB1137.namprd12.prod.outlook.com (10.168.226.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20b68cc7-bd04-464f-50e5-08d5214938a6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(48565401081)(2017052603199);SRVR:BN6PR12MB1137; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;3:Qisp2PsPY7nunAVxEdM/CYXpUIlkk4XDbWnCB9imbApKPemQxXqlbogIei3b6SePagqNqqTUE4VfFcCb9AlqrWxqG0gPs7u802Iaaul8CKbI5J7rGqecoZpnxcWiuZBBMyyr56a85uBJh/6xsIxkYk1qD+bR4WuCnJG67N8VH1I/yFRCVZ5d30KkEQU39AWYH2B3fyHo84s79axwHRKC3sIOL84ERDNukJ2bg8j/n+dVG8gwo7wBnUVmHsm10lC7;25:FNmhA3NSdQByJRJGzAD4rn7fbIkVc1jF5oa2JjdDFHcRXtz59Lwh24YuBXGDvvccjNKyI7fmBkjvt1fMoVA/Tbrz52a81UAegKgGtHwcWV7tmzu83hINTOw9loEPtQYuiYksfOcZPnkMmF0oaBHzF3LpAa5zMPnUIgDpDj3khFlufGHqD+7iO1bCbgzsHT5BUQFmtZvimLEt0OZcw1L7XQMoZ1KOqNOgIVQDdqzPAl/mlTkctqIgtLISXjQMS9tVi2sdgCTC6lfd/wlDaksbogjb7bZqxTiet0VFNTYxCup+S/7rVI5ZVoKt6GWP7xnvi8gP3/9negxsraDzfixeeg==;31:EiVEfWsYFLAJIgrgq2FCQWnenHI0b1EBSKnE3yFiaW6DmX3qtB0E5wH8Zv3gFZpM8Gv181KjnsoUd8TgooVQdgjpUvkIlvRH3LlL5IbjtYThcIZj/byhnOXUAV/wWAlYRkRl7Y7NenYXuq4EGt9xi5V74nXEGBnr/FFFkz890aZxCNWzg2JiVdyLOXB5/tAdR1kutiVR1tPHDQXMRFRWJZEVhZBXZrrgOkFZxJND6+4= X-MS-TrafficTypeDiagnostic: BN6PR12MB1137: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;20:eOIwSmSMhl2TwiLrGAnlGq9u4Vt/GoWZXGvHjU67w55X09lE26lZ1TSvl8qVaRFNz5A5dm1MN9yGkel/qYqKDKdqf5R1yAUWcf0WB2scBnunb768h3ezXJYWV6M6IBekCHiDpKftpKd4/WVkZD2LWrrOTKwcGIc9zk10jMcctmuook9QIH/rSzFoiizOVV8ke1UTRjV3eLssYsZvNKs9Ov5maKqCckbPaOJlJCn9/WS2xMh4J2rCjICtpQApSBKGNOicugGw+Xa57BWQPElQuy8Nok6bh3kt9AvAqnwrbjUAZsaFTDAzMUywRgNR/ferfkNhnrp9GbvwtNM0ouYX5uQNa2jT7Re2utgU7zpiumWj7jjkomi5Pz2eVh1sVpCHdRmeLuXElZEKHyv42om0crTE3f0OLVgBbt0aW6n/NzyH4wmCU75bZQ0JMpFviGDOTRNIvoy2TybJSSQagPQr62kAIvyGN2GAuH//1Xq1LNt5kIydALkh4eun3z1i15Fr;4:ZH0/3psCTfXc484psdG3oYXPPX66BkkzumoYnR68welKjviN5EnETeivfhSbSNyQbU5wn/byBzzreEepEFQ30+I2nvlZNIYbTUUAXd1t7ueQP03acoAe8wDa6/CTFP7WUb2CPA4r3uo3ZDO7iJ1KK1mWdCwpN/4Aesk3rHq2t0gN0tygugN5jawbmF6BlGGMtLqSOC3NU9enW5dhgXjoGPOaQXevAV3SAG9zWXYPWhZqBOS7qC1rt6sUiEFU4KfH32oXHkT03mXyd9IYsdWvWOGbvjTOHYKhTCbpkZQrkqSnZZ+69EgzaBIfLHEMpxoQ/23SORk9sHmT4agw2q8NIitFZ4oJbvnQ9iizuGBn/XY= X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(6055026)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR12MB1137;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR12MB1137; X-Forefront-PRVS: 0478C23FE0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(199003)(16526018)(189998001)(68736007)(3846002)(2906002)(69596002)(6116002)(7736002)(5660300001)(6506006)(6666003)(6916009)(305945005)(4326008)(55016002)(1076002)(83506002)(86362001)(230700001)(316002)(9686003)(33646002)(58126008)(8936002)(54906003)(97746001)(478600001)(54356999)(50986999)(50466002)(2361001)(81156014)(72206003)(66066001)(103116003)(2351001)(53416004)(101416001)(25786009)(47776003)(23676003)(8676002)(106356001)(53936002)(97736004)(105586002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1137;H:tlendack-t1.amdoffice.net;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMTM3OzIzOlRlUXBxVlFTYld0R3hhNXF0OXd5b1JZU2RM?= =?utf-8?B?SnV5WkV4WHNWWkMxaURIWWFLTU4xYjZWS1FvUW92ZFBob3NKaXR2Ly8zZlJj?= =?utf-8?B?Y1RHT2JDdDhmNDlYYkFUM29GbDgyK2tiZlhSdzFhYVVsWWZuS3krL2FzSXZj?= =?utf-8?B?ZnFpZHRxWGVacnF4c2dPSlR5ZVJ4Mnp1TkdtNDQ1Y1FmeCtISEJ3Y0w5L0VG?= =?utf-8?B?RERHMXd2TkhEdUZQREtBV09rUnpjeUpKN0p6QTZ6VGxGaTMzUW95RzFrcHlB?= =?utf-8?B?bG8yUXZLVUlQQzRpZmpaQnJLeGNiUDFHdEFES1BDWG1ROUxHV0RVVEVaOHRB?= =?utf-8?B?SU44NkVGUUtGVzFnMi9rYlVwUTZlVDU3VE1FektvN2JWVVVxS3Z0Z2RoOXV5?= =?utf-8?B?aTh2RXFBYy8zL0tUS2pFSFF3ZEEzT0RERjh5NFBzVFlyL1dCMHoxWWkzWFRN?= =?utf-8?B?OGNwamF1SHVsQzllb1VzNXRhMlBGTmJhVXVRSVY4d2xUalFnQml0QjVHTzNL?= =?utf-8?B?N2dEdUZQOWtCS0ZocVIrV3RVVC9pS0t3dE5FUEZMTmdyejhBM29JZFNaQzNT?= =?utf-8?B?Qll1VlZsR2V5M1Q4Wk1nSkh2T21ucHNFYXNWWXNLRUl6LzYrcUFBMnlmK1cx?= =?utf-8?B?YWxlOGdyVVZpQkI5YTRZV0JFL2tac2E3SG1XMW9IeVg5QzlYa3Y0cDhQRVdk?= =?utf-8?B?Q0NNNUs0MXN1UHQvek52MTFhOVdlVW0rbEdCeTZDeXQwdW1aTHFUbjZHUXhq?= =?utf-8?B?YjhvNVVySjJrZGVXQzJHZFM1MURGSmV6Ym9zNEo3d3gxcjR4dG8xMjkzQndL?= =?utf-8?B?RTZhV3JuRXRXWE8zR05xNlJSYWMwNk81UG55UTJCd3lTREVoU0dTQ0xyT0Mv?= =?utf-8?B?emwxS3V5SVdFUFJwUzBzTnFWOFZDTzNrc2swKzZSME5aZktvcWx2SlZuaTYx?= =?utf-8?B?NHN6QXR0QkVDamxGcmNJQTNhcUl0QWJnZDNBeHphWDRLSU1DVWlMb0FqK3o3?= =?utf-8?B?QVVhN01uSm5lNFRBSjBaRFY2Q0pkTXVhZzlIY1l3YUliRkNuRjVBdER4OFZK?= =?utf-8?B?TnFtK2xCaklsZUkrR0pvTTMyYU93ZUxPUXBuUWlKdmJoYUowZlpEZVFic2da?= =?utf-8?B?ZFRTbGQ3SWlGdUlLSnA2V0xxcDk5NUVxTmUrK3ZoREg1anhSd2s2bHhKclIx?= =?utf-8?B?aTFiRjR2VXM3LzNvNi9GZjJJeDVFNjlGSmlSZ1A4MzEzZFo5S2l6QTloam43?= =?utf-8?B?cVVudzdkdEVLaFlJRzFoWHpHR3RHMFBlOFRKbW5LeGozbUJTQUh4cUU4dWY2?= =?utf-8?B?OGlZcW9xeDRtOTFCSUZHWm5NSjJRMjRkdXJmbHNxK3VvUVJNNmZNYTdBVWJ5?= =?utf-8?B?YlVmcFptZVFaRS9ML0FNazJ2YXF2MVk1VEJaRW1xbFhpZGJSMXVHZjVacXRQ?= =?utf-8?B?bU1pSkhvWVNjcGlOODBJYUtPQ2oyNUpMR1ZiajdYdXExM2ZHRnc2dlV6UGNH?= =?utf-8?B?MDZ1d3lKbGJ5QkR6TnFBVkNxcTJpMnAvNEY4VmZ4RmQrZTNmUWpxdDE1NzFw?= =?utf-8?B?eW05QmRuZXZ6ZXo4bll5Ykdwc3RmY0Y3dTNGSFZJd0RidWlHc2RMQ0Raay9w?= =?utf-8?B?TVZ4cktiNWlETXphVEFpUU9qeU5aMTMzUkVUWnVXY1pXeklNbUNYWFZRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;6:P7GsNmH0cgep7ZYR1OvBDr/z+hs9wxNduDouGa/HCnQJeNMphDGBzA9KXE7YwM1IA3kVtI3IH2y8z1TDRkXD1LOPNLXsYmjYm/aJ+hOxH+1GAniqubVG8BsthY3sisxcRgelMtl/bBs+twWVXSieYK3gZbbEwJdRp9/H7gnd3EeiQziOwyTsoU5laQVPwDceex7D4XawNwpvJWkxZpFvueDvtnIdcr/F7FoRz7bixM6ABy7i6bezAxBVuE5UfEloAQ/IMQ1X6U6Q/pmmsASfY0X004un3i5Buta5+wtWglfEKtpt1ZzFjZnbBFXLJIF7sB2QX7RUqpUmUPv0dzkZ+ck8jTVeASQaJconRbHFwRA=;5:zkCsrfwLlIMB2pEIFn0eJOxzBPrm/Op9Qe5M3e1TsMjYnrFLPzk97E7bR9BNfkbKOn8oIJVRY9sl/x1YxOnedfhOC9jwJh9hREpHnfrL3VFXO7A7sW4Sz3Fmp0cG7O9IRTzwQLjmxCPw+YPV2OXcL3YLKOpaz2gTl3Qen5+w5ZA=;24:trFQp1QgkcpZm8U7+rmjNq7WKdvjCGpNHUIuV9L/WicCbUuXKRVLVJYQ8dnKc9qW0uHHe1Z7iw0PAoW0JZlvHQq6f0IgPYJViL1dS5mjCUU=;7:7YpTa51X+EwR6jpI5oNSL8OBHYc6nkS6+G3K3Ls+1zpxrGcys+aPb8e6VfrMAsgRKE3Xw+Nno97BP1OyRWII2l630gdSaNFQ7nkojXgCMwkJj9h4A0fnP2olf58n+g+RbIBQQmw6VhDlyzXHP2RJATlenNJhzOpcPo1xbl2EYoaJbvd8++cnkg+Uqtfg3lKTj+Y0B8KIceQvZFY40l9M9aK3mBMtDtKuvA/aGZ6wOzb3iONUjqhonzbUnf96DrJY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1137;20:mwhdK2yNQYlCClzxzzpjnp+h0OxWAUwPiHIPodx4bLEQQAq5qrmIWRcU3t5eRUT3IIVY1T4FiFEmOK69hRyiJDN9xmf59vv3Xvuq7+lkQEt6hYYLCP5bfYuAudjF2YUxdiIzdM3OJX1+0sqfrYdFL1tkdGrMXGfFH0sj/XfK/P50WzMlpm40Lan5NNEH+w+P/AiQ+L6LsDUicIoGHJb1Pw1VWI+g+qmt8/JgaKraazOis1r4s/BNUECfqAakTggz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2017 16:54:30.0483 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20b68cc7-bd04-464f-50e5-08d5214938a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A TLB flush is not required when doing in-place encryption or decryption since the area's pagetable attributes are not being altered. To avoid confusion between what the routine is doing and what is documented in the AMD APM, delete the local_flush_tlb() call. Suggested-by: Dave Hansen Signed-off-by: Tom Lendacky --- arch/x86/mm/mem_encrypt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c index 16c5f37..53680a9 100644 --- a/arch/x86/mm/mem_encrypt.c +++ b/arch/x86/mm/mem_encrypt.c @@ -63,7 +63,6 @@ static void __init __sme_early_enc_dec(resource_size_t paddr, if (!sme_me_mask) return; - local_flush_tlb(); wbinvd(); /*