From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915: Don't try to use negative pll_id. Date: Wed, 1 Nov 2017 12:08:52 -0700 Message-ID: <20171101190851.GB28377@intel.com> References: <20171101184458.31698-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F93C6E816 for ; Wed, 1 Nov 2017 19:03:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171101184458.31698-1-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMTE6NDQ6NThBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IEl0IGlzIHVubGlrZWx5IHdlIGFyZSBnZXR0aW5nIHRoZSAtMSBoZXJlLgo+IEJ1dCBp ZiB3ZSBwcm9wYWdhdGUgdGhhdCBwbGxfaWQgLTEgdG8gdGhlIHJlc3Qgb2YgdGhlIGNvZGUKPiB3 ZSBtaWdodCBoYXZlIGZ1bm55IGNhbGN1bGF0aW9ucyBvbiBsaW5rX2Nsb2NrIGFuZCB3aG8KPiBr bm93cyB3aGF0IHJlZ2lzdGVycyB3ZSBlbmQgdXAgYWNjZXNzaW5nLgo+IAo+IEJldHRlciB0byBw cm90ZWN0IHRoZSBjb2RlLgo+IAo+IEFsc28gYmV0dGVyIHdpdGggZXJybm8gbnVtYmVyIGluc3Rl YWQgb2YgZ2VuZXJpYyAtMS4KPiAKPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJl QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBp bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jICAgICAg fCAxMCArKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMg fCAgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IGFjZTY3NGNkNzliOS4uMmM2 YWJkYmYzM2VhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMTI4Myw2ICsx MjgzLDExIEBAIHN0YXRpYyB2b2lkIGNubF9kZGlfY2xvY2tfZ2V0KHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyLAo+ICAKPiAgCXBsbF9pZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChk ZXZfcHJpdiwgcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiAgCj4gKwlpZiAocGxsX2lkIDwg MCkgewo+ICsJCURSTV9FUlJPUigiUExMIG5vdCBmb3VuZFxuIik7Cj4gKwkJcmV0dXJuOwo+ICsJ fQo+ICsKClRoZSBmdW5jdGlvbiBpbnRlbF9nZXRfc2hhcmVkX2RwbGxfaWQoKSBhbHJlYWR5IGhh cyB0aGlzIFdBUk5fT046CmlmIChXQVJOX09OKHBsbCA8IGRldl9wcml2LT5zaGFyZWRfZHBsbHMp KQphbmQgaXQgcmV0dXJuIHBsbF9pZCA9IChwbGwgLSBkZXZfcHJpdi0+c2hhcmVkX2RwbGxzKTsK U28gc2hvdWxkbnQgdGhpcyBhbHJlYWR5IHRocm93IGEgd2FybmluZyBpbiBjYXNlIHBsbCA8IGRl dl9wcml2LT5zaGFyZWRfZHBsbHMgZXZlbnR1YWxseQpyZXN1bHRpbmcgaW50byBhIG5lZ2F0aXZl IHBsbF9pZD8KCk1hbmFzaQoKPiAgCWNmZ2NyMCA9IEk5MTVfUkVBRChDTkxfRFBMTF9DRkdDUjAo cGxsX2lkKSk7Cj4gIAo+ICAJaWYgKGNmZ2NyMCAmIERQTExfQ0ZHQ1IwX0hETUlfTU9ERSkgewo+ IEBAIC0xMzM3LDYgKzEzNDIsMTEgQEAgc3RhdGljIHZvaWQgc2tsX2RkaV9jbG9ja19nZXQoc3Ry dWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAo+ICAJcGxsX2lkID0gaW50ZWxfZ2V0X3No YXJlZF9kcGxsX2lkKGRldl9wcml2LCBwaXBlX2NvbmZpZy0+c2hhcmVkX2RwbGwpOwo+ICAKPiAr CWlmIChwbGxfaWQgPCAwKSB7Cj4gKwkJRFJNX0VSUk9SKCJQTEwgbm90IGZvdW5kXG4iKTsKPiAr CQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICAJZHBsbF9jdGwxID0gSTkxNV9SRUFEKERQTExfQ1RSTDEp Owo+ICAKPiAgCWlmIChkcGxsX2N0bDEgJiBEUExMX0NUUkwxX0hETUlfTU9ERShwbGxfaWQpKSB7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggYTgzYmYxYzM4ZTA1 Li5jNGE3ZjM5ZTE3M2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBsbF9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMK PiBAQCAtMTAyLDcgKzEwMiw3IEBAIGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHsKPiAgCWlmIChXQVJOX09OKHBsbCA8IGRldl9w cml2LT5zaGFyZWRfZHBsbHN8fAo+ICAJCSAgICBwbGwgPiAmZGV2X3ByaXYtPnNoYXJlZF9kcGxs c1tkZXZfcHJpdi0+bnVtX3NoYXJlZF9kcGxsXSkpCj4gLQkJcmV0dXJuIC0xOwo+ICsJCXJldHVy biAtRU5PRU5UOwo+ICAKPiAgCXJldHVybiAoZW51bSBpbnRlbF9kcGxsX2lkKSAocGxsIC0gZGV2 X3ByaXYtPnNoYXJlZF9kcGxscyk7Cj4gIH0KPiAtLSAKPiAyLjEzLjYKPiAKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==