From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755032AbdKATdM (ORCPT ); Wed, 1 Nov 2017 15:33:12 -0400 Received: from mail-yw0-f180.google.com ([209.85.161.180]:51515 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbdKATdJ (ORCPT ); Wed, 1 Nov 2017 15:33:09 -0400 X-Google-Smtp-Source: ABhQp+Tg/hI3sqWLYobymsdCdMF4u/Qr6MMdoS4T16sdMDle2HgBex9CkltYUKlCjpYXH9z+v+HZ8Q== Date: Wed, 1 Nov 2017 15:33:07 -0400 From: Sean Paul To: JeffyChen Cc: Heiko Stuebner , seanpaul@chromium.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, Andrzej Hajda , Arnd Bergmann , Romain Perier , Russell King , Philipp Zabel , Jonathan Corbet , dri-devel@lists.freedesktop.org, Jingoo Han , David Airlie , Kevin Hilman , Catalin Marinas , Laurent Pinchart , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , Inki Dae , linux-rockchip@lists.infradead.org, Kyungmin Park , Carlo Caione , Will Deacon , linux-amlogic@lists.infradead.org, Caesar Wang , Matthias Kaehlcke , devicetree@vger.kerne, Kukjin Kim , Tomeu Vizoso , zain wang , Hans Verkuil , Archit Taneja , Joonyoung Shim , linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Daniel Vetter , Mark Yao , linux-renesas-soc@vger.kernel.org, Neil Armstrong , Kieran Bingham , Rob Herring , Jose Abreu , Mark Rutland Subject: Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display Message-ID: <20171101193307.4pnn6u5keo7o5yut@art_vandelay> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <2449324.8EdsLz1NaV@phil> <59F7FE17.80405@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59F7FE17.80405@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote: > Hi Heiko, > > On 10/31/2017 07:01 AM, Heiko Stuebner wrote: > > As I was just looking at the edp dts change in patch1 again, does this > > series also contain a fix for the issue below [0] ? > > > > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in. > > > i saw that too, it should due to our psr code...i think Zain has solved > these in chromeos kernel, i will ask Zain if he have time to upstream them, > or maybe i'll try to upstream them. You need the patchset where I've refactored the psr locking/workers. I have a version of it based on Heiko's tree at https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display With this kernel, the backlight comes on, but I don't have anything on the display (which is why I didn't post it). I'll try putting this set on top and see what happens. Sean > > > > Heiko > > > > [0] > > > > [ 27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x00000002 > > [ 27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl > > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie pcie_rockchip > > [ 28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: G W 4.14.0-rc7-03201-g12490811b353 #559 > > [ 28.008774] Hardware name: Google Kevin (DT) > > [ 28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm] > > [ 28.008828] Call trace: > > [ 28.008838] [] dump_backtrace+0x0/0x378 > > [ 28.008842] [] show_stack+0x14/0x20 > > [ 28.008847] [] dump_stack+0x9c/0xbc > > [ 28.008852] [] __schedule_bug+0x4c/0x70 > > [ 28.008856] [] __schedule+0x558/0x5e8 > > [ 28.008859] [] schedule+0x38/0xa0 > > [ 28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8 > > [ 28.008867] [] schedule_hrtimeout_range+0x10/0x18 > > [ 28.008870] [] usleep_range+0x64/0x78 > > [ 28.008882] [] analogix_dp_transfer+0x16c/0xa88 [analogix_dp] > > [ 28.008891] [] analogix_dpaux_transfer+0x10/0x18 [analogix_dp] > > [ 28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 [drm_kms_helper] > > [ 28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper] > > [ 28.009002] [] analogix_dp_disable_psr+0x60/0xb0 [analogix_dp] > > [ 28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm] > > [ 28.009040] [] process_one_work+0x1d4/0x348 > > [ 28.009043] [] worker_thread+0x48/0x470 > > [ 28.009048] [] kthread+0x12c/0x130 > > [ 28.009052] [] ret_from_fork+0x10/0x18 > > > > > > > > > > -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display Date: Wed, 1 Nov 2017 15:33:07 -0400 Message-ID: <20171101193307.4pnn6u5keo7o5yut@art_vandelay> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <2449324.8EdsLz1NaV@phil> <59F7FE17.80405@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <59F7FE17.80405@rock-chips.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: JeffyChen Cc: Heiko Stuebner , seanpaul@chromium.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, Andrzej Hajda , Arnd Bergmann , Romain Perier , Russell King , Philipp Zabel , Jonathan Corbet , dri-devel@lists.freedesktop.org, Jingoo Han , David Airlie , Kevin Hilman , Catalin Marinas , Laurent Pinchart , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , Inki Dae List-Id: linux-samsung-soc@vger.kernel.org On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote: > Hi Heiko, > > On 10/31/2017 07:01 AM, Heiko Stuebner wrote: > > As I was just looking at the edp dts change in patch1 again, does this > > series also contain a fix for the issue below [0] ? > > > > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in. > > > i saw that too, it should due to our psr code...i think Zain has solved > these in chromeos kernel, i will ask Zain if he have time to upstream them, > or maybe i'll try to upstream them. You need the patchset where I've refactored the psr locking/workers. I have a version of it based on Heiko's tree at https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display With this kernel, the backlight comes on, but I don't have anything on the display (which is why I didn't post it). I'll try putting this set on top and see what happens. Sean > > > > Heiko > > > > [0] > > > > [ 27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x00000002 > > [ 27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl > > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie pcie_rockchip > > [ 28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: G W 4.14.0-rc7-03201-g12490811b353 #559 > > [ 28.008774] Hardware name: Google Kevin (DT) > > [ 28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm] > > [ 28.008828] Call trace: > > [ 28.008838] [] dump_backtrace+0x0/0x378 > > [ 28.008842] [] show_stack+0x14/0x20 > > [ 28.008847] [] dump_stack+0x9c/0xbc > > [ 28.008852] [] __schedule_bug+0x4c/0x70 > > [ 28.008856] [] __schedule+0x558/0x5e8 > > [ 28.008859] [] schedule+0x38/0xa0 > > [ 28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8 > > [ 28.008867] [] schedule_hrtimeout_range+0x10/0x18 > > [ 28.008870] [] usleep_range+0x64/0x78 > > [ 28.008882] [] analogix_dp_transfer+0x16c/0xa88 [analogix_dp] > > [ 28.008891] [] analogix_dpaux_transfer+0x10/0x18 [analogix_dp] > > [ 28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 [drm_kms_helper] > > [ 28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper] > > [ 28.009002] [] analogix_dp_disable_psr+0x60/0xb0 [analogix_dp] > > [ 28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm] > > [ 28.009040] [] process_one_work+0x1d4/0x348 > > [ 28.009043] [] worker_thread+0x48/0x470 > > [ 28.009048] [] kthread+0x12c/0x130 > > [ 28.009052] [] ret_from_fork+0x10/0x18 > > > > > > > > > > -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Wed, 1 Nov 2017 15:33:07 -0400 Subject: [PATCH v6 00/10] rockchip: kevin: Enable edp display In-Reply-To: <59F7FE17.80405@rock-chips.com> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <2449324.8EdsLz1NaV@phil> <59F7FE17.80405@rock-chips.com> Message-ID: <20171101193307.4pnn6u5keo7o5yut@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote: > Hi Heiko, > > On 10/31/2017 07:01 AM, Heiko Stuebner wrote: > > As I was just looking at the edp dts change in patch1 again, does this > > series also contain a fix for the issue below [0] ? > > > > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in. > > > i saw that too, it should due to our psr code...i think Zain has solved > these in chromeos kernel, i will ask Zain if he have time to upstream them, > or maybe i'll try to upstream them. You need the patchset where I've refactored the psr locking/workers. I have a version of it based on Heiko's tree at https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display With this kernel, the backlight comes on, but I don't have anything on the display (which is why I didn't post it). I'll try putting this set on top and see what happens. Sean > > > > Heiko > > > > [0] > > > > [ 27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x00000002 > > [ 27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl > > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie pcie_rockchip > > [ 28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: G W 4.14.0-rc7-03201-g12490811b353 #559 > > [ 28.008774] Hardware name: Google Kevin (DT) > > [ 28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm] > > [ 28.008828] Call trace: > > [ 28.008838] [] dump_backtrace+0x0/0x378 > > [ 28.008842] [] show_stack+0x14/0x20 > > [ 28.008847] [] dump_stack+0x9c/0xbc > > [ 28.008852] [] __schedule_bug+0x4c/0x70 > > [ 28.008856] [] __schedule+0x558/0x5e8 > > [ 28.008859] [] schedule+0x38/0xa0 > > [ 28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8 > > [ 28.008867] [] schedule_hrtimeout_range+0x10/0x18 > > [ 28.008870] [] usleep_range+0x64/0x78 > > [ 28.008882] [] analogix_dp_transfer+0x16c/0xa88 [analogix_dp] > > [ 28.008891] [] analogix_dpaux_transfer+0x10/0x18 [analogix_dp] > > [ 28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 [drm_kms_helper] > > [ 28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper] > > [ 28.009002] [] analogix_dp_disable_psr+0x60/0xb0 [analogix_dp] > > [ 28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm] > > [ 28.009040] [] process_one_work+0x1d4/0x348 > > [ 28.009043] [] worker_thread+0x48/0x470 > > [ 28.009048] [] kthread+0x12c/0x130 > > [ 28.009052] [] ret_from_fork+0x10/0x18 > > > > > > > > > > -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Wed, 1 Nov 2017 15:33:07 -0400 Subject: [PATCH v6 00/10] rockchip: kevin: Enable edp display In-Reply-To: <59F7FE17.80405@rock-chips.com> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <2449324.8EdsLz1NaV@phil> <59F7FE17.80405@rock-chips.com> Message-ID: <20171101193307.4pnn6u5keo7o5yut@art_vandelay> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote: > Hi Heiko, > > On 10/31/2017 07:01 AM, Heiko Stuebner wrote: > > As I was just looking at the edp dts change in patch1 again, does this > > series also contain a fix for the issue below [0] ? > > > > I'm still seeing this on 4.14-rc6 with the most recent drm tree merged in. > > > i saw that too, it should due to our psr code...i think Zain has solved > these in chromeos kernel, i will ask Zain if he have time to upstream them, > or maybe i'll try to upstream them. You need the patchset where I've refactored the psr locking/workers. I have a version of it based on Heiko's tree at https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display With this kernel, the backlight comes on, but I don't have anything on the display (which is why I didn't post it). I'll try putting this set on top and see what happens. Sean > > > > Heiko > > > > [0] > > > > [ 27.960120] BUG: scheduling while atomic: kworker/1:1/68/0x00000002 > > [ 27.974429] Modules linked in: rockchipdrm dw_hdmi analogix_dp drm_kms_helper panel_simple crc32_ce drm crct10dif_ce rockchip_saradc pwm_bl pwm_cros_ec rockchip_thermal ip_tables x_tabl > > es ipv6 smsc95xx smsc75xx ax88179_178a asix usbnet phy_rockchip_pcie pcie_rockchip > > [ 28.008769] CPU: 1 PID: 68 Comm: kworker/1:1 Tainted: G W 4.14.0-rc7-03201-g12490811b353 #559 > > [ 28.008774] Hardware name: Google Kevin (DT) > > [ 28.008825] Workqueue: events analogix_dp_psr_work [rockchipdrm] > > [ 28.008828] Call trace: > > [ 28.008838] [] dump_backtrace+0x0/0x378 > > [ 28.008842] [] show_stack+0x14/0x20 > > [ 28.008847] [] dump_stack+0x9c/0xbc > > [ 28.008852] [] __schedule_bug+0x4c/0x70 > > [ 28.008856] [] __schedule+0x558/0x5e8 > > [ 28.008859] [] schedule+0x38/0xa0 > > [ 28.008864] [] schedule_hrtimeout_range_clock+0x84/0xe8 > > [ 28.008867] [] schedule_hrtimeout_range+0x10/0x18 > > [ 28.008870] [] usleep_range+0x64/0x78 > > [ 28.008882] [] analogix_dp_transfer+0x16c/0xa88 [analogix_dp] > > [ 28.008891] [] analogix_dpaux_transfer+0x10/0x18 [analogix_dp] > > [ 28.008950] [] drm_dp_dpcd_access+0x4c/0xf8 [drm_kms_helper] > > [ 28.008994] [] drm_dp_dpcd_write+0x1c/0x28 [drm_kms_helper] > > [ 28.009002] [] analogix_dp_disable_psr+0x60/0xb0 [analogix_dp] > > [ 28.009036] [] analogix_dp_psr_work+0x4c/0xc0 [rockchipdrm] > > [ 28.009040] [] process_one_work+0x1d4/0x348 > > [ 28.009043] [] worker_thread+0x48/0x470 > > [ 28.009048] [] kthread+0x12c/0x130 > > [ 28.009052] [] ret_from_fork+0x10/0x18 > > > > > > > > > > -- Sean Paul, Software Engineer, Google / Chromium OS