From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934142AbdKAVyJ (ORCPT ); Wed, 1 Nov 2017 17:54:09 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:52012 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933080AbdKAVyG (ORCPT ); Wed, 1 Nov 2017 17:54:06 -0400 X-Google-Smtp-Source: ABhQp+TRkglRlQZJ0eOwQfJl6Q+59INBnNUeidXCogCRWEnZD545JDxlIR98BOBbl/6rYJbEzAnLtQ== Date: Wed, 1 Nov 2017 16:54:04 -0500 From: Rob Herring To: Joel Stanley Cc: Jonathan Cameron , Rick Altherr , Philipp Zabel , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: adc: aspeed: Deassert reset in probe Message-ID: <20171101215404.njw5zch55dxwmkgl@rob-hp-laptop> References: <20171031021203.18248-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031021203.18248-1-joel@jms.id.au> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 12:42:03PM +1030, Joel Stanley wrote: > The ASPEED SoC must deassert a reset in order to use the ADC peripheral. > > The device tree bindings are updated to document the resets phandle, and > the example is updated to match what is expected for both the reset and > clock phandle. Note that the bindings should have always had the reset > controller, as the hardware is unusable without it. > > Signed-off-by: Joel Stanley > --- > v2: > - Ensure disabling path unwinds in opposite order as the enable path > - Note that the bindings were incorrect without the reset phandle, > and for the system to be usable we must update them. No one was > (successfully) using these bindings/driver before without out of tree > hacks in mach-aspeed, as it would not have worked. > > .../devicetree/bindings/iio/adc/aspeed_adc.txt | 4 +++- > drivers/iio/adc/aspeed_adc.c | 25 ++++++++++++++++------ > 2 files changed, 22 insertions(+), 7 deletions(-) Acked-by: Rob Herring