From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933481AbdKAWRO (ORCPT ); Wed, 1 Nov 2017 18:17:14 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:53930 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933402AbdKAWRN (ORCPT ); Wed, 1 Nov 2017 18:17:13 -0400 X-Google-Smtp-Source: ABhQp+SdqEMzmkozRsy2lAqMMicjKF2tbC3gZ3DB3WkU/QDElJW+UL1jwP16gMYEhbQNnQTzhFV/Eg== Date: Wed, 1 Nov 2017 15:17:09 -0700 From: Bjorn Andersson To: Sudeep Holla Cc: Jassi Brar , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann Subject: Re: [PATCH] mailbox: add support for doorbell/signal mode controllers Message-ID: <20171101221709.GB28761@minitux> References: <1509553964-4451-1-git-send-email-sudeep.holla@arm.com> <59a05fcb-ff30-0683-144e-93521a7413f9@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59a05fcb-ff30-0683-144e-93521a7413f9@arm.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: > > 80 writel_relaxed(msg->cmd, mb->mbox_base + > MAILBOX_A2B_CMD(chans->idx)); > 81 writel_relaxed(msg->rx_size, mb->mbox_base + > > 82 MAILBOX_A2B_DAT(chans->idx)); > > 83 This is just terrible, using the void *mssg to pass a struct which is interpreted by the controller removes any form of abstraction provided by the framework. In my view the void *mssg should point to the data to be written in the mailbox register, and hence might be of different size - but only of native type. Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn.andersson@linaro.org (Bjorn Andersson) Date: Wed, 1 Nov 2017 15:17:09 -0700 Subject: [PATCH] mailbox: add support for doorbell/signal mode controllers In-Reply-To: <59a05fcb-ff30-0683-144e-93521a7413f9@arm.com> References: <1509553964-4451-1-git-send-email-sudeep.holla@arm.com> <59a05fcb-ff30-0683-144e-93521a7413f9@arm.com> Message-ID: <20171101221709.GB28761@minitux> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote: > > 80 writel_relaxed(msg->cmd, mb->mbox_base + > MAILBOX_A2B_CMD(chans->idx)); > 81 writel_relaxed(msg->rx_size, mb->mbox_base + > > 82 MAILBOX_A2B_DAT(chans->idx)); > > 83 This is just terrible, using the void *mssg to pass a struct which is interpreted by the controller removes any form of abstraction provided by the framework. In my view the void *mssg should point to the data to be written in the mailbox register, and hence might be of different size - but only of native type. Regards, Bjorn