From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdKBLxd (ORCPT ); Thu, 2 Nov 2017 07:53:33 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37444 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbdKBLxc (ORCPT ); Thu, 2 Nov 2017 07:53:32 -0400 Date: Thu, 2 Nov 2017 12:53:19 +0100 From: Borislav Petkov To: Tom Lendacky Cc: x86@kernel.org, Peter Zijlstra , linux-kernel@vger.kernel.org, Dave Hansen , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH] x86/mm: Remove unneeded TLB flush for in-place encryption Message-ID: <20171102115319.itui72sn76ajuf6e@pd.tnic> References: <20171101165426.1388.24866.stgit@tlendack-t1.amdoffice.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171101165426.1388.24866.stgit@tlendack-t1.amdoffice.net> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 01, 2017 at 11:54:26AM -0500, Tom Lendacky wrote: > A TLB flush is not required when doing in-place encryption or decryption > since the area's pagetable attributes are not being altered. To avoid > confusion between what the routine is doing and what is documented in > the AMD APM, delete the local_flush_tlb() call. > > Suggested-by: Dave Hansen > Signed-off-by: Tom Lendacky > --- > arch/x86/mm/mem_encrypt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index 16c5f37..53680a9 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -63,7 +63,6 @@ static void __init __sme_early_enc_dec(resource_size_t paddr, > if (!sme_me_mask) > return; > > - local_flush_tlb(); > wbinvd(); > > /* Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.