From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754816AbdKBMxV (ORCPT ); Thu, 2 Nov 2017 08:53:21 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38991 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbdKBMxU (ORCPT ); Thu, 2 Nov 2017 08:53:20 -0400 Date: Thu, 2 Nov 2017 13:53:05 +0100 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, rafal@milecki.pl, stephen@networkplumber.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h Message-ID: <20171102125305.GI4772@lunn.ch> References: <20171102093648.4141-1-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171102093648.4141-1-privat@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2017 at 10:36:48AM +0100, Egil Hjelmeland wrote: > Why: Please drop the Why. > The lan9303 driver defines eth_stp_addr as a synonym to > eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00. > > eth_reserved_addr_base is also used to define the start of Bridge Reserved > ethernet address range, which happen to be the STP address. > > br_dev_setup refer to eth_reserved_addr_base as a definition of STP > address. > > Clean up by: > - Move the eth_stp_addr definition to linux/etherdevice.h > - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup. > > Signed-off-by: Egil Hjelmeland I was thinking along the same lines when reviewing your lan9303 patch. Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 2 Nov 2017 13:53:05 +0100 From: Andrew Lunn Message-ID: <20171102125305.GI4772@lunn.ch> References: <20171102093648.4141-1-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171102093648.4141-1-privat@egil-hjelmeland.no> Subject: Re: [Bridge] [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Egil Hjelmeland Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, rafal@milecki.pl On Thu, Nov 02, 2017 at 10:36:48AM +0100, Egil Hjelmeland wrote: > Why: Please drop the Why. > The lan9303 driver defines eth_stp_addr as a synonym to > eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00. > > eth_reserved_addr_base is also used to define the start of Bridge Reserved > ethernet address range, which happen to be the STP address. > > br_dev_setup refer to eth_reserved_addr_base as a definition of STP > address. > > Clean up by: > - Move the eth_stp_addr definition to linux/etherdevice.h > - Use eth_stp_addr instead of eth_reserved_addr_base in br_dev_setup. > > Signed-off-by: Egil Hjelmeland I was thinking along the same lines when reviewing your lan9303 patch. Reviewed-by: Andrew Lunn Andrew