From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Thu, 2 Nov 2017 13:04:06 +0000 Subject: [PATCH 3/3] ARM: early_printk: use printascii() rather than printch() In-Reply-To: References: <20171031175344.GJ9463@n2100.armlinux.org.uk> <20171031182024.GK9463@n2100.armlinux.org.uk> <20171102000945.GT9463@n2100.armlinux.org.uk> <20171102112041.GW9463@n2100.armlinux.org.uk> Message-ID: <20171102130406.GY9463@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 02, 2017 at 11:28:55AM +0000, Chris Brandt wrote: > On Thursday, November 02, 2017, Russell King - ARM Linux wrote: > > So, as far as ARM assembly in the Linux kernel goes, all constants must > > be preceded by # whether or not binutils requires it - no exceptions. > > Please always test assembly changes with a binutils version that is not > > gratuitously broken! > > Somewhat ironic since Nicolas works for Linaro. Sorry, I don't see the connection. As Nicolas has already admitted, he didn't actually test the patch because the code was configured out of his test build. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up