From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933648AbdKBOt6 (ORCPT ); Thu, 2 Nov 2017 10:49:58 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10004 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933612AbdKBOty (ORCPT ); Thu, 2 Nov 2017 10:49:54 -0400 Date: Thu, 2 Nov 2017 14:49:32 +0000 From: Jonathan Cameron To: Joel Stanley CC: Philipp Zabel , Jonathan Cameron , Rick Altherr , Rob Herring , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , , devicetree , LKML Subject: Re: [PATCH v2] iio: adc: aspeed: Deassert reset in probe Message-ID: <20171102144932.00001e17@huawei.com> In-Reply-To: References: <20171031021203.18248-1-joel@jms.id.au> X-Mailer: Claws Mail 3.15.0 (GTK+ 2.24.31; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.45.96.99] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.59FB308A.0138,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 93ff5004d50df52bd063bcb86e38043a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Nov 2017 10:15:32 +1030 Joel Stanley wrote: > On Tue, Oct 31, 2017 at 10:28 PM, Philipp Zabel > wrote: > > On Tue, Oct 31, 2017 at 3:12 AM, Joel Stanley > > wrote: > >> The ASPEED SoC must deassert a reset in order to use the ADC > >> peripheral. > >> > >> The device tree bindings are updated to document the resets > >> phandle, and the example is updated to match what is expected for > >> both the reset and clock phandle. Note that the bindings should > >> have always had the reset controller, as the hardware is unusable > >> without it. > >> > >> Signed-off-by: Joel Stanley > > > > It is unfortunate that this has to break DT (theoretical) backwards > > compatibility, but given that the old bindings never worked, > > this is better than to pretend a required reset is optional. > > > > Reviewed-by: Philipp Zabel > > Thanks. I agree that it's unfortunate; this has been my first time > working on an ARM SoC and there were few things we could have done > better in hindsight. > > I've got similar patches for the ASPEED hwmon pwm/tach driver, and the > i2c driver that I'll send out now. > > Thanks for the review. > > Cheers, > > Joel Hi Joel, IIO is closed for this cycle anyway now. Otherwise, series looks good. Will pick up when back with my main PC as traveling for this week and next. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" > in the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v2] iio: adc: aspeed: Deassert reset in probe Date: Thu, 2 Nov 2017 14:49:32 +0000 Message-ID: <20171102144932.00001e17@huawei.com> References: <20171031021203.18248-1-joel@jms.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Joel Stanley Cc: Philipp Zabel , Jonathan Cameron , Rick Altherr , Rob Herring , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devicetree , LKML List-Id: devicetree@vger.kernel.org On Wed, 1 Nov 2017 10:15:32 +1030 Joel Stanley wrote: > On Tue, Oct 31, 2017 at 10:28 PM, Philipp Zabel > wrote: > > On Tue, Oct 31, 2017 at 3:12 AM, Joel Stanley > > wrote: > >> The ASPEED SoC must deassert a reset in order to use the ADC > >> peripheral. > >> > >> The device tree bindings are updated to document the resets > >> phandle, and the example is updated to match what is expected for > >> both the reset and clock phandle. Note that the bindings should > >> have always had the reset controller, as the hardware is unusable > >> without it. > >> > >> Signed-off-by: Joel Stanley > > > > It is unfortunate that this has to break DT (theoretical) backwards > > compatibility, but given that the old bindings never worked, > > this is better than to pretend a required reset is optional. > > > > Reviewed-by: Philipp Zabel > > Thanks. I agree that it's unfortunate; this has been my first time > working on an ARM SoC and there were few things we could have done > better in hindsight. > > I've got similar patches for the ASPEED hwmon pwm/tach driver, and the > i2c driver that I'll send out now. > > Thanks for the review. > > Cheers, > > Joel Hi Joel, IIO is closed for this cycle anyway now. Otherwise, series looks good. Will pick up when back with my main PC as traveling for this week and next. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" > in the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html